Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] add missing server checks to integration tests #81818

Merged
merged 1 commit into from
Oct 27, 2020
Merged

[Ingest Manager] add missing server checks to integration tests #81818

merged 1 commit into from
Oct 27, 2020

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Oct 27, 2020 •
edited
Loading

Checks need to be added for whether the server is enabled in all before, after, and afterEach hooks.
This is a continuation from #80779. skipIfDockerRegistry only skips beforeEach. That fixed some of the tests but not others.

Test failing: #80273.

@neptunian neptunian added v8.0.0 v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Oct 27, 2020
@neptunian neptunian self-assigned this Oct 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@neptunian neptunian added the release_note:skip Skip the PR/issue when compiling release notes label Oct 27, 2020
@neptunian neptunian merged commit b1aa93f into elastic:master Oct 27, 2020
@neptunian neptunian deleted the 80273-add-server-checks-for-tests branch October 27, 2020 19:08
@neptunian neptunian mentioned this pull request Oct 27, 2020
Merged
neptunian added a commit to neptunian/kibana that referenced this pull request Oct 27, 2020
@neptunian
check for server enabled (elastic#81818)
b6c8a90
@neptunian neptunian mentioned this pull request Oct 27, 2020
Merged
neptunian added a commit to neptunian/kibana that referenced this pull request Oct 27, 2020
@neptunian
check for server enabled (elastic#81818)
96817dd
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Test Failures

X-Pack API Integration Tests.x-pack/test/api_integration/apis/maps/proxy_api·js.apis Maps endpoints EMS proxy should correctly rewrite url and format

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 6 times on tracked branches: https://github.com/elastic/kibana/issues/81844

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:04:55]           └-: Maps endpoints
[00:04:55]             └-> "before all" hook
[00:04:55]             └-> "before all" hook
[00:04:55]               │ info [logstash_functional] Loading "mappings.json"
[00:04:55]               │ info [logstash_functional] Loading "data.json.gz"
[00:04:55]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1603826978171882345] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:04:55]               │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:04:55]               │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:04:55]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1603826978171882345] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:04:55]               │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:04:55]               │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:04:55]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1603826978171882345] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:04:55]               │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:04:55]               │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:03]               │ info [logstash_functional] Indexed 4634 docs into "logstash-2015.09.22"
[00:05:03]               │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:05:03]               │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:05:04]             └-: 
[00:05:04]               └-> "before all" hook
[00:05:05]               └-: EMS proxy
[00:05:05]                 └-> "before all" hook
[00:05:05]                 └-> should correctly rewrite url and format
[00:05:05]                   └-> "before each" hook: global before each
[00:05:05]                   └- ✖ fail: apis Maps endpoints  EMS proxy should correctly rewrite url and format
[00:05:05]                   │      Error: expected 'topojson' to equal 'geojson'
[00:05:05]                   │       at Assertion.assert (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:100:11)
[00:05:05]                   │       at Assertion.be.Assertion.equal (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:227:8)
[00:05:05]                   │       at Assertion.be (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:69:22)
[00:05:05]                   │       at Context.it (test/api_integration/apis/maps/proxy_api.js:24:45)
[00:05:05]                   │ 
[00:05:05]                   │

Stack Trace

Error: expected 'topojson' to equal 'geojson'
    at Assertion.assert (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.it (test/api_integration/apis/maps/proxy_api.js:24:45)
X-Pack API Integration Tests.x-pack/test/api_integration/apis/maps/proxy_api·js.apis Maps endpoints EMS proxy should correctly rewrite url and format

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 6 times on tracked branches: https://github.com/elastic/kibana/issues/81844

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:05:04]           └-: Maps endpoints
[00:05:04]             └-> "before all" hook
[00:05:04]             └-> "before all" hook
[00:05:04]               │ info [logstash_functional] Loading "mappings.json"
[00:05:04]               │ info [logstash_functional] Loading "data.json.gz"
[00:05:04]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1603826978171882345] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:05:04]               │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:05:04]               │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:04]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1603826978171882345] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:05:04]               │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:05:04]               │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:04]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1603826978171882345] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:05:04]               │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:05:04]               │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:12]               │ info [logstash_functional] Indexed 4634 docs into "logstash-2015.09.22"
[00:05:12]               │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:05:12]               │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:05:12]             └-: 
[00:05:12]               └-> "before all" hook
[00:05:13]               └-: EMS proxy
[00:05:13]                 └-> "before all" hook
[00:05:13]                 └-> should correctly rewrite url and format
[00:05:13]                   └-> "before each" hook: global before each
[00:05:13]                   └- ✖ fail: apis Maps endpoints  EMS proxy should correctly rewrite url and format
[00:05:13]                   │      Error: expected 'topojson' to equal 'geojson'
[00:05:13]                   │       at Assertion.assert (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:100:11)
[00:05:13]                   │       at Assertion.be.Assertion.equal (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:227:8)
[00:05:13]                   │       at Assertion.be (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:69:22)
[00:05:13]                   │       at Context.it (test/api_integration/apis/maps/proxy_api.js:24:45)
[00:05:13]                   │ 
[00:05:13]                   │

Stack Trace

Error: expected 'topojson' to equal 'geojson'
    at Assertion.assert (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:227:8)
    at Assertion.be (/dev/shm/workspace/parallel/3/kibana/packages/kbn-expect/expect.js:69:22)
    at Context.it (test/api_integration/apis/maps/proxy_api.js:24:45)

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 28, 2020
@gmmorris
Merge branch 'task-manager/lost-connectivity' of github.com:gmmorris/…
f72c4f5 
…kibana into task-manager/lost-connectivity

* 'task-manager/lost-connectivity' of github.com:gmmorris/kibana:
  skips overview tests (elastic#81877)
  [Security Solution][Case] Fix connector's labeling (elastic#81824)
  [Maps] Fix EMS test (elastic#81856)
  [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783)
  skip flaky suite (elastic#81853)
  Add tsconfig for url_forwarding (elastic#81177)
  skip flaky suite (elastic#81844)
  check for server enabled (elastic#81818)
  [Seurity Solution][Case] Create case plugin client (elastic#81018)
  [Security Solutions][Detection Engine] Changes wording for threat matches and rules (elastic#81334)
  [Security Solution] critical pref bug with browser fields reducer
neptunian added a commit that referenced this pull request Oct 28, 2020
@neptunian @kibanamachine
check for server enabled (#81818) (#81841)
393050e 
Co-authored-by: Kibana Machine <[email protected]>
neptunian added a commit that referenced this pull request Oct 28, 2020
@neptunian @kibanamachine
check for server enabled (#81818) (#81840)
542423a 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

Assignees

@neptunian neptunian

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neptunian @elasticmachine @kibanamachine @jen-huang