Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] add skipIfNoDockerRegistry to package_install_complete test #80779

Merged

Conversation

neptunian
Copy link
Contributor

Addresses EPM failing tests in #80273.

  • setup checks packages completed install integration test for EPM has 404s which I think are because these tests aren't meant to run in this environment. This adds the check skipIfNoDockerRegistry if the registry does not exist.
  • datastreams test is failing because afterEach still runs even with skipIfNoDockerRegistry, this adds a manual check for it. Should have a better solution in the future.

@neptunian neptunian added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v7.11.0 v8.0.0 labels Oct 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii self-requested a review October 16, 2020 01:27
@neptunian neptunian merged commit d859ad3 into elastic:master Oct 16, 2020
neptunian added a commit to neptunian/kibana that referenced this pull request Oct 16, 2020
…te test (elastic#80779)

* fix missing skipIfNoDockerRegistry

* skip afterEach if server doesn't exist
neptunian added a commit to neptunian/kibana that referenced this pull request Oct 16, 2020
…te test (elastic#80779)

* fix missing skipIfNoDockerRegistry

* skip afterEach if server doesn't exist
@neptunian neptunian deleted the fix-missing-skipIfNoDockerRegistry branch October 16, 2020 11:46
neptunian added a commit that referenced this pull request Oct 16, 2020
…te test (#80779) (#80817)

* fix missing skipIfNoDockerRegistry

* skip afterEach if server doesn't exist
neptunian added a commit that referenced this pull request Oct 16, 2020
…te test (#80779) (#80818)

* fix missing skipIfNoDockerRegistry

* skip afterEach if server doesn't exist

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 19, 2020
* master: (51 commits)
  [Discover] Unskip flaky test (elastic#80670)
  Fix security solution template label (elastic#80754)
  [Ingest]: ignore 404, check if there are transforms in results. (elastic#80721)
  Moving loader to logo in header, add a slight 250ms pause (elastic#78879)
  [Security Solution][Cases] Fix bug with case connectors (elastic#80642)
  Update known-plugins.asciidoc (elastic#75388)
  [Lens] Add median operation (elastic#79453)
  Fix navigateToApp logic when navigating to the current app. (elastic#80809)
  [Visualizations] Fix bad color mapping with multiple split series (elastic#80801)
  [ILM] Add esErrorHandler for the new es js client (elastic#80302)
  Fix codeowners (elastic#80826)
  skip flaky suite (elastic#79463)
  [Timelion] Remove kui usage (elastic#80287)
  [Ingest Manager] add skipIfNoDockerRegistry to package_install_complete test (elastic#80779)
  [Alerting UI] Disable "Save" button for Alerts with broken Connectors (elastic#80579)
  Allow the default space to be accessed via `/s/default` (elastic#77109)
  Add script to identify plugin dependencies for TS project references migration (elastic#80463)
  [Search] Client side session service (elastic#76889)
  feat: 🎸 add separator for different context menu groups (elastic#80498)
  Lazy load reporting (elastic#80492)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants