Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time to Visualize] Update Library Text with Call to Action #81667

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Oct 26, 2020

Summary

Changes the copy on the library notification popover to add a call to action.

closes #81354

New Copy:
Screen Shot 2020-10-27 at 11 04 11 AM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Project:TimeToVisualize labels Oct 26, 2020
@ThomThomson ThomThomson requested a review from a team as a code owner October 26, 2020 19:38
@ThomThomson ThomThomson force-pushed the fix/unlinkCallToAction branch from 9644e4d to f57ce60 Compare October 26, 2020 19:57
@ThomThomson ThomThomson force-pushed the fix/unlinkCallToAction branch from f57ce60 to 8a5dd0e Compare October 26, 2020 20:15
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
dashboard 344.3KB 344.4KB +19.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 6b1409b into elastic:master Oct 27, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Oct 27, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 27, 2020
* master: (87 commits)
  [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81778)
  [i18n] add get_kibana_translation_paths tests (elastic#81624)
  [UX] Fix search term reset from url (elastic#81654)
  [Lens] Improved range formatter (elastic#80132)
  [Resolver] `SideEffectContext` changes, remove `@testing-library` uses (elastic#81077)
  [Time to Visualize] Update Library Text with Call to Action (elastic#81667)
  [docs] Resolving failed Kibana upgrade migrations (elastic#80999)
  [ftr/menuToggle] provide helper for enhanced menu toggle handling (elastic#81709)
  [Task Manager] adds basic observability into Task Manager's runtime operations (elastic#77868)
  Doc changes for stack management and grouped feature privileges (elastic#80486)
  Added functional test for alerts list filters by status, alert type and action type. Did a code refactoring and splitting for alerts tests. (elastic#81422)
  [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415)
  Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)"
  [Maps] Use default format when proxying EMS-files (elastic#79760)
  [Discover] Deangularize context.html (elastic#81442)
  Use the displayName property in default editor (elastic#73311)
  adds bug label to Bug report for Security Solution template (elastic#81643)
  [ML] Transforms: Remove index field limitation for custom query. (elastic#81467)
  [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)
  [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681)
  ...
ThomThomson added a commit that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:TimeToVisualize release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Time to Visualize] Library Notification Call To Action
3 participants