Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc changes for stack management and grouped feature privileges #80486

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

legrego
Copy link
Member

@legrego legrego commented Oct 14, 2020

[skip ci]

  1. Improves the documentation for Stack Management to include the minimum set of privileges required to access most features. There are a couple of entries within the Data section which are managed outside of the Kibana repo, so they will need PRs in their respective repositories to include the minimum set of privileges.

  2. Updates the Roles and Spaces screenshots to reflect the updated designs

Doc Preview: https://kibana_80486.docs-preview.app.elstc.co/diff

Resolves #79329

@legrego legrego added docs release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.10.0 v7.11.0 v8.0.0 labels Oct 14, 2020
@legrego legrego marked this pull request as ready for review October 14, 2020 11:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from gchaps October 14, 2020 11:44
@gchaps
Copy link
Contributor

gchaps commented Oct 14, 2020

@legrego Should there be a general statement in the Stack Management overview to indicate that some features require privileges. So you only see what you have privileges for?

@legrego
Copy link
Member Author

legrego commented Oct 14, 2020

@legrego Should there be a general statement in the Stack Management overview to indicate that some features require privileges. So you only see what you have privileges for?

I tried to include this here, but perhaps it could be clearer?

https://github.com/elastic/kibana/pull/80486/files#diff-e89fb827dce87bcb975c28c269de9146d5427688c3f287d953ae46efd33e0ad4

docs/management/advanced-options.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-beats.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-fields.asciidoc Outdated Show resolved Hide resolved
docs/management/managing-saved-objects.asciidoc Outdated Show resolved Hide resolved
docs/user/security/authorization/index.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Kaarina Tungseth <[email protected]>
Co-authored-by: gchaps <[email protected]>
@legrego
Copy link
Member Author

legrego commented Oct 16, 2020

@KOTungseth thanks for the initial review - should we hold off on this one until #80407 merges?

@legrego legrego requested a review from KOTungseth October 26, 2020 16:51
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legrego legrego merged commit 8fa93bc into elastic:master Oct 27, 2020
@legrego legrego deleted the docs/grouped-features-stack-mgmt branch October 27, 2020 15:41
legrego added a commit to legrego/kibana that referenced this pull request Oct 27, 2020
…tic#80486)

Co-authored-by: Kaarina Tungseth <[email protected]>
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/intro-spaces.jpg
legrego added a commit that referenced this pull request Oct 27, 2020
…#80486) (#81795)

Co-authored-by: Kaarina Tungseth <[email protected]>
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/intro-spaces.jpg
legrego added a commit that referenced this pull request Oct 27, 2020
#80486) (#81796)

Co-authored-by: Kaarina Tungseth <[email protected]>
Co-authored-by: gchaps <[email protected]>
# Conflicts:
#	docs/images/intro-spaces.jpg
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 27, 2020
* master: (87 commits)
  [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81778)
  [i18n] add get_kibana_translation_paths tests (elastic#81624)
  [UX] Fix search term reset from url (elastic#81654)
  [Lens] Improved range formatter (elastic#80132)
  [Resolver] `SideEffectContext` changes, remove `@testing-library` uses (elastic#81077)
  [Time to Visualize] Update Library Text with Call to Action (elastic#81667)
  [docs] Resolving failed Kibana upgrade migrations (elastic#80999)
  [ftr/menuToggle] provide helper for enhanced menu toggle handling (elastic#81709)
  [Task Manager] adds basic observability into Task Manager's runtime operations (elastic#77868)
  Doc changes for stack management and grouped feature privileges (elastic#80486)
  Added functional test for alerts list filters by status, alert type and action type. Did a code refactoring and splitting for alerts tests. (elastic#81422)
  [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415)
  Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)"
  [Maps] Use default format when proxying EMS-files (elastic#79760)
  [Discover] Deangularize context.html (elastic#81442)
  Use the displayName property in default editor (elastic#73311)
  adds bug label to Bug report for Security Solution template (elastic#81643)
  [ML] Transforms: Remove index field limitation for custom query. (elastic#81467)
  [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)
  [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify privileges granted to Saved Object Management feature
4 participants