Adding defaults and fixing unit tests #8096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,8 +65,8 @@ export default function ($compile) { | |||
| run: (item) => this.toggle(item.key) | |||
| }, opt); | |||
|
|
|||
| defaultedOpt.hideButton = isFunction(opt.hideButton) ? opt.hideButton : () => opt.hideButton; | |||
| defaultedOpt.disableButton = isFunction(opt.disableButton) ? opt.disableButton : () => opt.disableButton; | |||
| defaultedOpt.hideButton = isFunction(opt.hideButton) ? opt.hideButton : () => !!opt.hideButton || false; | |||
There was a problem hiding this comment.
These defaults are not necessary because the !! forces the value to be either true or false.
There was a problem hiding this comment.
Ah yes, of course. Removing.
|
LGTM |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Adding defaults and fixing unit tests Former-commit-id: 78cc0d9
cee-chen
added a commit
that referenced
this pull request
Oct 31, 2024
`v97.2.0`⏩`v97.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.0`](https://github.com/elastic/eui/releases/v97.3.0) - `EuiDataGrid` now supports a new `toolbarVisibility.showDisplaySelector.customRender` function that allows completely customizing the rendering of the display selector popover ([#8080](elastic/eui#8080)) - `EuiDataGrid`'s row height/lines per row setting has been streamlined in both UI and UX ([#8080](elastic/eui#8080)) - `EuiDataGrid` now accepts consumer-passed display setting updates even after users have changed their display preferences via UI ([#8080](elastic/eui#8080)) - Updated `EuiDataGrid` to vertically center all `toolbarVisibility.additionalControls` nodes ([#8085](elastic/eui#8085)) - Updated `EuiDataGrid` with a beta `rowHeightsOptions.autoBelowLineCount` feature flag ([#8096](elastic/eui#8096)) - Updated `EuiContextMenuPanel` to allow disabling initial focus via `initialFocusedItemIndex={-1}` ([#8101](elastic/eui#8101)) **Bug fixes** - Fixed `EuiComment`'s typing to correctly reflect all accepted props ([#8089](elastic/eui#8089)) - Fixed `EuiSelectableTemplateSitewide`s within dark-themed `EuiHeader`s missing input borders ([#8100](elastic/eui#8100))
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
`v97.2.0`⏩`v97.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.3.0`](https://github.com/elastic/eui/releases/v97.3.0) - `EuiDataGrid` now supports a new `toolbarVisibility.showDisplaySelector.customRender` function that allows completely customizing the rendering of the display selector popover ([elastic#8080](elastic/eui#8080)) - `EuiDataGrid`'s row height/lines per row setting has been streamlined in both UI and UX ([elastic#8080](elastic/eui#8080)) - `EuiDataGrid` now accepts consumer-passed display setting updates even after users have changed their display preferences via UI ([elastic#8080](elastic/eui#8080)) - Updated `EuiDataGrid` to vertically center all `toolbarVisibility.additionalControls` nodes ([elastic#8085](elastic/eui#8085)) - Updated `EuiDataGrid` with a beta `rowHeightsOptions.autoBelowLineCount` feature flag ([elastic#8096](elastic/eui#8096)) - Updated `EuiContextMenuPanel` to allow disabling initial focus via `initialFocusedItemIndex={-1}` ([elastic#8101](elastic/eui#8101)) **Bug fixes** - Fixed `EuiComment`'s typing to correctly reflect all accepted props ([elastic#8089](elastic/eui#8089)) - Fixed `EuiSelectableTemplateSitewide`s within dark-themed `EuiHeader`s missing input borders ([elastic#8100](elastic/eui#8100)) (cherry picked from commit 4e7d43a)
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Upgrade EUI to v97.3.0 (#198087)](#198087) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-31T02:41:45Z","message":"Upgrade EUI to v97.3.0 (#198087)\n\n`v97.2.0`⏩`v97.3.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.3.0`](https://github.com/elastic/eui/releases/v97.3.0)\r\n\r\n- `EuiDataGrid` now supports a new\r\n`toolbarVisibility.showDisplaySelector.customRender` function that\r\nallows completely customizing the rendering of the display selector\r\npopover ([#8080](https://github.com/elastic/eui/pull/8080))\r\n- `EuiDataGrid`'s row height/lines per row setting has been streamlined\r\nin both UI and UX ([#8080](https://github.com/elastic/eui/pull/8080))\r\n- `EuiDataGrid` now accepts consumer-passed display setting updates even\r\nafter users have changed their display preferences via UI\r\n([#8080](https://github.com/elastic/eui/pull/8080))\r\n- Updated `EuiDataGrid` to vertically center all\r\n`toolbarVisibility.additionalControls` nodes\r\n([#8085](https://github.com/elastic/eui/pull/8085))\r\n- Updated `EuiDataGrid` with a beta\r\n`rowHeightsOptions.autoBelowLineCount` feature flag\r\n([#8096](https://github.com/elastic/eui/pull/8096))\r\n- Updated `EuiContextMenuPanel` to allow disabling initial focus via\r\n`initialFocusedItemIndex={-1}`\r\n([#8101](https://github.com/elastic/eui/pull/8101))\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiComment`'s typing to correctly reflect all accepted props\r\n([#8089](https://github.com/elastic/eui/pull/8089))\r\n- Fixed `EuiSelectableTemplateSitewide`s within dark-themed `EuiHeader`s\r\nmissing input borders\r\n([#8100](https://github.com/elastic/eui/pull/8100))","sha":"4e7d43a03181ab95719733cc0a44d4896481841f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","backport:version","v8.17.0"],"title":"Upgrade EUI to v97.3.0","number":198087,"url":"https://github.com/elastic/kibana/pull/198087","mergeCommit":{"message":"Upgrade EUI to v97.3.0 (#198087)\n\n`v97.2.0`⏩`v97.3.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.3.0`](https://github.com/elastic/eui/releases/v97.3.0)\r\n\r\n- `EuiDataGrid` now supports a new\r\n`toolbarVisibility.showDisplaySelector.customRender` function that\r\nallows completely customizing the rendering of the display selector\r\npopover ([#8080](https://github.com/elastic/eui/pull/8080))\r\n- `EuiDataGrid`'s row height/lines per row setting has been streamlined\r\nin both UI and UX ([#8080](https://github.com/elastic/eui/pull/8080))\r\n- `EuiDataGrid` now accepts consumer-passed display setting updates even\r\nafter users have changed their display preferences via UI\r\n([#8080](https://github.com/elastic/eui/pull/8080))\r\n- Updated `EuiDataGrid` to vertically center all\r\n`toolbarVisibility.additionalControls` nodes\r\n([#8085](https://github.com/elastic/eui/pull/8085))\r\n- Updated `EuiDataGrid` with a beta\r\n`rowHeightsOptions.autoBelowLineCount` feature flag\r\n([#8096](https://github.com/elastic/eui/pull/8096))\r\n- Updated `EuiContextMenuPanel` to allow disabling initial focus via\r\n`initialFocusedItemIndex={-1}`\r\n([#8101](https://github.com/elastic/eui/pull/8101))\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiComment`'s typing to correctly reflect all accepted props\r\n([#8089](https://github.com/elastic/eui/pull/8089))\r\n- Fixed `EuiSelectableTemplateSitewide`s within dark-themed `EuiHeader`s\r\nmissing input borders\r\n([#8100](https://github.com/elastic/eui/pull/8100))","sha":"4e7d43a03181ab95719733cc0a44d4896481841f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198087","number":198087,"mergeCommit":{"message":"Upgrade EUI to v97.3.0 (#198087)\n\n`v97.2.0`⏩`v97.3.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.3.0`](https://github.com/elastic/eui/releases/v97.3.0)\r\n\r\n- `EuiDataGrid` now supports a new\r\n`toolbarVisibility.showDisplaySelector.customRender` function that\r\nallows completely customizing the rendering of the display selector\r\npopover ([#8080](https://github.com/elastic/eui/pull/8080))\r\n- `EuiDataGrid`'s row height/lines per row setting has been streamlined\r\nin both UI and UX ([#8080](https://github.com/elastic/eui/pull/8080))\r\n- `EuiDataGrid` now accepts consumer-passed display setting updates even\r\nafter users have changed their display preferences via UI\r\n([#8080](https://github.com/elastic/eui/pull/8080))\r\n- Updated `EuiDataGrid` to vertically center all\r\n`toolbarVisibility.additionalControls` nodes\r\n([#8085](https://github.com/elastic/eui/pull/8085))\r\n- Updated `EuiDataGrid` with a beta\r\n`rowHeightsOptions.autoBelowLineCount` feature flag\r\n([#8096](https://github.com/elastic/eui/pull/8096))\r\n- Updated `EuiContextMenuPanel` to allow disabling initial focus via\r\n`initialFocusedItemIndex={-1}`\r\n([#8101](https://github.com/elastic/eui/pull/8101))\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiComment`'s typing to correctly reflect all accepted props\r\n([#8089](https://github.com/elastic/eui/pull/8089))\r\n- Fixed `EuiSelectableTemplateSitewide`s within dark-themed `EuiHeader`s\r\nmissing input borders\r\n([#8100](https://github.com/elastic/eui/pull/8100))","sha":"4e7d43a03181ab95719733cc0a44d4896481841f"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to PR #8084. This PR contains the unit tests and default values that should've been part of #8084 😞