Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SECURITY SOLUTION] bug styling #80572

Merged
merged 6 commits into from
Oct 15, 2020
Merged

[SECURITY SOLUTION] bug styling #80572

merged 6 commits into from
Oct 15, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Oct 14, 2020

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Oct 14, 2020
@XavierM XavierM requested review from a team as code owners October 14, 2020 18:30
@XavierM XavierM self-assigned this Oct 14, 2020
stephmilovic
stephmilovic approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @XavierM

kevinlog
kevinlog approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin pages look good!

spong
spong approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally and LGTM once 🟢! Thanks @XavierM! 👍

@elastic elastic deleted a comment from kibanamachine Oct 15, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
securitySolution 2059 2057 -2

async chunks size

id before after diff
securitySolution 10.9MB 10.9MB -1.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 41db7d1 into elastic:master Oct 15, 2020
@XavierM XavierM mentioned this pull request Oct 15, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Oct 15, 2020
@XavierM
[SECURITY SOLUTION] bug styling (elastic#80572)
b10edb0 
* remove beta

* fix i18n

* fix cypress tests

* forget to save

* x-pack test
XavierM added a commit to XavierM/kibana that referenced this pull request Oct 15, 2020
@XavierM
[SECURITY SOLUTION] bug styling (elastic#80572)
544e49c 
* remove beta

* fix i18n

* fix cypress tests

* forget to save

* x-pack test
@XavierM XavierM mentioned this pull request Oct 15, 2020
Merged
XavierM added a commit that referenced this pull request Oct 15, 2020
@XavierM
[SECURITY SOLUTION] bug styling (#80572) (#80716)
aa1fb14 
* remove beta

* fix i18n

* fix cypress tests

* forget to save

* x-pack test
XavierM added a commit that referenced this pull request Oct 15, 2020
@XavierM
[SECURITY SOLUTION] bug styling (#80572) (#80717)
cf211d2 
* remove beta

* fix i18n

* fix cypress tests

* forget to save

* x-pack test
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@kevinlog kevinlog kevinlog approved these changes

@spong spong spong approved these changes

Assignees

@XavierM XavierM

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @kibanamachine @spong @stephmilovic @kevinlog @MindyRS