[SECURITY SOLUTION] bug styling (#80572) (#80717)

* remove beta * fix i18n * fix cypress tests * forget to save * x-pack test
elastic · Oct 15, 2020 · cf211d2 · cf211d2
1 parent 58f152a
commit cf211d2
Show file tree

Hide file tree

Showing 19 changed files with 14 additions and 84 deletions.
diff --git a/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts b/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts
@@ -168,7 +168,7 @@ describe('Custom detection rules creation', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${newRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${newRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', newRule.severity);
@@ -328,7 +328,7 @@ describe('Custom detection rules deletion and edition', () => {
       fillAboutRule(editedRule);
       saveEditedRule();
 
-      cy.get(RULE_NAME_HEADER).should('have.text', `${editedRule.name} Beta`);
+      cy.get(RULE_NAME_HEADER).should('have.text', `${editedRule.name}`);
       cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', editedRule.description);
       cy.get(ABOUT_DETAILS).within(() => {
         getDetails(SEVERITY_DETAILS).should('have.text', editedRule.severity);

diff --git a/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_eql.spec.ts b/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_eql.spec.ts
@@ -129,7 +129,7 @@ describe('Detection rules, EQL', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${eqlRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${eqlRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', eqlRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', eqlRule.severity);

diff --git a/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_ml.spec.ts b/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_ml.spec.ts
@@ -115,7 +115,7 @@ describe('Detection rules, machine learning', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${machineLearningRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${machineLearningRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', machineLearningRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', machineLearningRule.severity);

diff --git a/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_override.spec.ts b/x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_override.spec.ts
@@ -132,7 +132,7 @@ describe('Detection rules, override', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${newOverrideRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${newOverrideRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newOverrideRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', newOverrideRule.severity);

diff --git a/...ck/plugins/security_solution/cypress/integration/alerts_detection_rules_threshold.spec.ts b/...ck/plugins/security_solution/cypress/integration/alerts_detection_rules_threshold.spec.ts
@@ -129,7 +129,7 @@ describe('Detection rules, threshold', () => {
 
     goToRuleDetails();
 
-    cy.get(RULE_NAME_HEADER).should('have.text', `${newThresholdRule.name} Beta`);
+    cy.get(RULE_NAME_HEADER).should('have.text', `${newThresholdRule.name}`);
     cy.get(ABOUT_RULE_DESCRIPTION).should('have.text', newThresholdRule.description);
     cy.get(ABOUT_DETAILS).within(() => {
       getDetails(SEVERITY_DETAILS).should('have.text', newThresholdRule.severity);

diff --git a/x-pack/plugins/security_solution/cypress/integration/cases.spec.ts b/x-pack/plugins/security_solution/cypress/integration/cases.spec.ts
@@ -60,7 +60,7 @@ describe('Cases', () => {
     createNewCaseWithTimeline(case1);
     backToCases();
 
-    cy.get(ALL_CASES_PAGE_TITLE).should('have.text', 'Cases Beta');
+    cy.get(ALL_CASES_PAGE_TITLE).should('have.text', 'Cases');
     cy.get(ALL_CASES_OPEN_CASES_STATS).should('have.text', 'Open cases1');
     cy.get(ALL_CASES_CLOSED_CASES_STATS).should('have.text', 'Closed cases0');
     cy.get(ALL_CASES_OPEN_CASES_COUNT).should('have.text', 'Open cases (1)');

diff --git a/x-pack/plugins/security_solution/public/cases/components/case_header_page/index.tsx b/x-pack/plugins/security_solution/public/cases/components/case_header_page/index.tsx
@@ -7,18 +7,9 @@
 import React from 'react';
 
 import { HeaderPage, HeaderPageProps } from '../../../common/components/header_page';
-import * as i18n from './translations';
 
 const CaseHeaderPageComponent: React.FC<HeaderPageProps> = (props) => (
   <HeaderPage hideSourcerer={true} {...props} />
 );
 
-CaseHeaderPageComponent.defaultProps = {
-  badgeOptions: {
-    beta: true,
-    text: i18n.PAGE_BADGE_LABEL,
-    tooltip: i18n.PAGE_BADGE_TOOLTIP,
-  },
-};
-
 export const CaseHeaderPage = React.memo(CaseHeaderPageComponent);
diff --git a/x-pack/plugins/security_solution/public/cases/components/case_header_page/translations.ts b/x-pack/plugins/security_solution/public/cases/components/case_header_page/translations.ts
diff --git a/x-pack/plugins/security_solution/public/common/store/sourcerer/model.ts b/x-pack/plugins/security_solution/public/common/store/sourcerer/model.ts
@@ -56,7 +56,7 @@ export const initSourcererScope = {
   errorMessage: null,
   indexPattern: EMPTY_INDEX_PATTERN,
   indicesExist: true,
-  loading: true,
+  loading: false,
   selectedPatterns: [],
 };
 

diff --git a/...ins/security_solution/public/detections/components/detection_engine_header_page/index.tsx b/...ins/security_solution/public/detections/components/detection_engine_header_page/index.tsx
@@ -7,20 +7,11 @@
 import React from 'react';
 
 import { HeaderPage, HeaderPageProps } from '../../../common/components/header_page';
-import * as i18n from './translations';
 
 const DetectionEngineHeaderPageComponent: React.FC<HeaderPageProps> = (props) => (
   <HeaderPage hideSourcerer={true} {...props} />
 );
 
-DetectionEngineHeaderPageComponent.defaultProps = {
-  badgeOptions: {
-    beta: true,
-    text: i18n.PAGE_BADGE_LABEL,
-    tooltip: i18n.PAGE_BADGE_TOOLTIP,
-  },
-};
-
 export const DetectionEngineHeaderPage = React.memo(DetectionEngineHeaderPageComponent);
 
 DetectionEngineHeaderPage.displayName = 'DetectionEngineHeaderPage';
diff --git a/...curity_solution/public/detections/components/detection_engine_header_page/translations.ts b/...curity_solution/public/detections/components/detection_engine_header_page/translations.ts
diff --git a/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx b/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx
@@ -561,7 +561,7 @@ export const EndpointList = () => {
   return (
     <AdministrationListPage
       data-test-subj="endpointPage"
-      beta={true}
+      beta={false}
       title={
         <FormattedMessage
           id="xpack.securitySolution.endpoint.list.pageTitle"

diff --git a/x-pack/plugins/security_solution/public/management/pages/policy/view/policy_list.tsx b/x-pack/plugins/security_solution/public/management/pages/policy/view/policy_list.tsx
@@ -405,7 +405,7 @@ export const PolicyList = React.memo(() => {
       )}
       <AdministrationListPage
         data-test-subj="policyListPage"
-        beta={true}
+        beta={false}
         title={
           <FormattedMessage
             id="xpack.securitySolution.policyList.pageTitle"

diff --git a/...plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_page.tsx b/...plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_page.tsx
@@ -67,7 +67,7 @@ export const TrustedAppsPage = memo(() => {
   return (
     <AdministrationListPage
       data-test-subj="trustedAppsListPage"
-      beta={true}
+      beta={false}
       title={
         <FormattedMessage
           id="xpack.securitySolution.trustedapps.list.pageTitle"

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -14834,8 +14834,6 @@
     "xpack.securitySolution.case.caseView.noTags": "現在、このケースにタグは割り当てられていません。",
     "xpack.securitySolution.case.caseView.openedOn": "開始日",
     "xpack.securitySolution.case.caseView.optional": "オプション",
-    "xpack.securitySolution.case.caseView.pageBadgeLabel": "ベータ",
-    "xpack.securitySolution.case.caseView.pageBadgeTooltip": "ケースワークフローはまだベータです。Kibana repoで問題や不具合を報告して製品の改善にご協力ください。",
     "xpack.securitySolution.case.caseView.particpantsLabel": "参加者",
     "xpack.securitySolution.case.caseView.pushNamedIncident": "{ thirdParty }インシデントとしてプッシュ",
     "xpack.securitySolution.case.caseView.pushThirdPartyIncident": "外部インシデントとしてプッシュ",
@@ -15211,8 +15209,6 @@
     "xpack.securitySolution.detectionEngine.emptyActionSecondary": "ドキュメントに移動",
     "xpack.securitySolution.detectionEngine.emptyTitle": "セキュリティアプリケーションの検出エンジンに関連したインデックスがないようです",
     "xpack.securitySolution.detectionEngine.goToDocumentationButton": "ドキュメンテーションを表示",
-    "xpack.securitySolution.detectionEngine.headerPage.pageBadgeLabel": "ベータ",
-    "xpack.securitySolution.detectionEngine.headerPage.pageBadgeTooltip": "アラートはまだベータ段階です。Kibana repoで問題や不具合を報告して製品の改善にご協力ください。",
     "xpack.securitySolution.detectionEngine.lastSignalTitle": "前回のアラート",
     "xpack.securitySolution.detectionEngine.mitreAttack.addTitle": "MITRE ATT&amp;CK\\u2122脅威を追加",
     "xpack.securitySolution.detectionEngine.mitreAttack.tacticPlaceHolderDescription": "Tacticを追加...",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -14843,8 +14843,6 @@
     "xpack.securitySolution.case.caseView.noTags": "当前没有为此案例分配标记。",
     "xpack.securitySolution.case.caseView.openedOn": "打开时间",
     "xpack.securitySolution.case.caseView.optional": "可选",
-    "xpack.securitySolution.case.caseView.pageBadgeLabel": "公测版",
-    "xpack.securitySolution.case.caseView.pageBadgeTooltip": "案例工作流仍为公测版。请通过在 Kibana 存储库中报告问题或错误，帮助我们改进产品。",
     "xpack.securitySolution.case.caseView.particpantsLabel": "参与者",
     "xpack.securitySolution.case.caseView.pushNamedIncident": "推送为 { thirdParty } 事件",
     "xpack.securitySolution.case.caseView.pushThirdPartyIncident": "推送为外部事件",
@@ -15220,8 +15218,6 @@
     "xpack.securitySolution.detectionEngine.emptyActionSecondary": "前往文档",
     "xpack.securitySolution.detectionEngine.emptyTitle": "似乎在 Security 应用程序中没有与检测引擎相关的索引",
     "xpack.securitySolution.detectionEngine.goToDocumentationButton": "查看文档",
-    "xpack.securitySolution.detectionEngine.headerPage.pageBadgeLabel": "公测版",
-    "xpack.securitySolution.detectionEngine.headerPage.pageBadgeTooltip": "告警仍为公测版。请通过在 Kibana 存储库中报告问题或错误，帮助我们改进产品。",
     "xpack.securitySolution.detectionEngine.lastSignalTitle": "上一告警",
     "xpack.securitySolution.detectionEngine.mitreAttack.addTitle": "添加 MITRE ATT&amp;CK\\u2122 威胁",
     "xpack.securitySolution.detectionEngine.mitreAttack.tacticPlaceHolderDescription": "选择策略......",

diff --git a/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts b/x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts
@@ -103,7 +103,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
 
       it('finds page title', async () => {
         const title = await testSubjects.getVisibleText('header-page-title');
-        expect(title).to.equal('Endpoints BETA');
+        expect(title).to.equal('Endpoints');
       });
 
       it('displays table data', async () => {

diff --git a/x-pack/test/security_solution_endpoint/apps/endpoint/policy_list.ts b/x-pack/test/security_solution_endpoint/apps/endpoint/policy_list.ts
@@ -30,7 +30,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
     });
     it('displays page title', async () => {
       const policyTitle = await testSubjects.getVisibleText('header-page-title');
-      expect(policyTitle).to.equal('Policies BETA');
+      expect(policyTitle).to.equal('Policies');
     });
     it('shows header create policy button', async () => {
       const createButtonTitle = await testSubjects.getVisibleText('headerCreateNewPolicyButton');

diff --git a/x-pack/test/security_solution_endpoint/apps/endpoint/trusted_apps_list.ts b/x-pack/test/security_solution_endpoint/apps/endpoint/trusted_apps_list.ts
@@ -20,7 +20,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
 
     it('should show page title', async () => {
       expect(await testSubjects.getVisibleText('header-page-title')).to.equal(
-        'Trusted Applications BETA'
+        'Trusted Applications'
       );
     });