-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ILM] Minor copy and link additions to cloud CTA for cold phase #80512
Merged
jloleysens
merged 7 commits into
elastic:master
from
jloleysens:ilm/cloud-callout-for-warm-and-cold-tier
Oct 21, 2020
Merged
[ILM] Minor copy and link additions to cloud CTA for cold phase #80512
jloleysens
merged 7 commits into
elastic:master
from
jloleysens:ilm/cloud-callout-for-warm-and-cold-tier
Oct 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add/updated component integration tests for checking callouts - sharing deployment url from cloud plugin
jloleysens
added
Feature:ILM
v8.0.0
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
v7.11.0
v7.10.1
labels
Oct 14, 2020
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
@elasticmachine merge upstream |
rudolf
approved these changes
Oct 14, 2020
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…lout-for-warm-and-cold-tier * 'master' of github.com:elastic/kibana: (126 commits) Add cumulative sum expression function (elastic#80129) [APM] Fix link to trace (elastic#80993) Provide url rewritten in onPreRouting interceptor (elastic#80810) limit renovate to npm packages Fix bug in logs UI link (elastic#80943) [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343) [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list docs test (elastic#81080) Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067) [APM] Fix service map highlighted edge on node select (elastic#80791) Fix typo in toast, slight copy adjustment. (elastic#80843) [Security Solution] reduce optimizer limits (elastic#80997) [maps] 7.10 documentation updates (elastic#79917) [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903) [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033) Upgrade EUI to v29.5.0 (elastic#80753) [Maps] Fix layer-flash when changing style (elastic#80948) [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220) [Enterprise Search] Handle loading state on Credentials page (elastic#80035) [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979) ...
jloleysens
changed the title
[ILM] Added CTA for warm phase on Cloud too
[ILM] Minor copy and link additions to cloud CTA for cold phase
Oct 20, 2020
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
cjcenizal
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, didn't test locally.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 21, 2020
…tic#80512) * Add CTA for warm phase too - add/updated component integration tests for checking callouts - sharing deployment url from cloud plugin * update comment * fix i18n * scope changes to cold phase only Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 21, 2020
…tic#80512) * Add CTA for warm phase too - add/updated component integration tests for checking callouts - sharing deployment url from cloud plugin * update comment * fix i18n * scope changes to cold phase only Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 21, 2020
…arm-phase-to-formlib * 'master' of github.com:elastic/kibana: (55 commits) [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106) [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082) [DOCS] Add link for monitoring ssl settings (elastic#81057) [test] Await loading indicator in monitoring test (elastic#81279) [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512) [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287) [Discover] Deangularize context.app (elastic#80851) [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873) [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671) Fix tagcloud word overlapping (elastic#81161) [Security Solution] Fixes flaky test rules (elastic#81040) Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183) [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301) Add namespaced version of the API call (elastic#81278) [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123) [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236) [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084) [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239) skip flaky suite (elastic#81264) [Maps] fix top-level Map page is called 'Kibana' (elastic#81238) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
jloleysens
added a commit
that referenced
this pull request
Oct 22, 2020
…) (#81324) * Add CTA for warm phase too - add/updated component integration tests for checking callouts - sharing deployment url from cloud plugin * update comment * fix i18n * scope changes to cold phase only Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Oct 22, 2020
…) (#81325) * Add CTA for warm phase too - add/updated component integration tests for checking callouts - sharing deployment url from cloud plugin * update comment * fix i18n * scope changes to cold phase only Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:ILM
NeededFor:Cloud
release_note:skip
Skip the PR/issue when compiling release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v7.10.0
v7.10.1
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #80023
Minor copy + link additions to #79650.
Updated notice states introduced here:
Also added the deployment link to the callout when we have it.
How to test
Same as #79650 for local cloud setup, but this time we are also checking the warm phase callout.
Screenshots
With link to deployment
Without link to deployment
Checklist
Delete any items that are not applicable to this PR.