-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Added reusable HiddenText component to Credentials #80033
[Enterprise Search] Added reusable HiddenText component to Credentials #80033
Conversation
a5064f3
to
1ad1078
Compare
x-pack/plugins/enterprise_search/public/applications/shared/hidden_text/hidden_text.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/enterprise_search/public/applications/shared/hidden_text/hidden_text.tsx
Show resolved
Hide resolved
x-pack/plugins/enterprise_search/public/applications/shared/hidden_text/hidden_text.tsx
Outdated
Show resolved
Hide resolved
...rprise_search/public/applications/app_search/components/credentials/credentials_list/key.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test comments
...e_search/public/applications/app_search/components/credentials/credentials_list/key.test.tsx
Outdated
Show resolved
Hide resolved
...e_search/public/applications/app_search/components/credentials/credentials_list/key.test.tsx
Outdated
Show resolved
Hide resolved
...e_search/public/applications/app_search/components/credentials/credentials_list/key.test.tsx
Outdated
Show resolved
Hide resolved
...e_search/public/applications/app_search/components/credentials/credentials_list/key.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/enterprise_search/public/applications/shared/hidden_text/hidden_text.test.tsx
Show resolved
Hide resolved
...ic/applications/app_search/components/credentials/credentials_list/credentials_list.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some remaining super small nit comments, and that's it from me!
.../public/applications/app_search/components/credentials/credentials_list/credentials_list.tsx
Outdated
Show resolved
Hide resolved
...ic/applications/app_search/components/credentials/credentials_list/credentials_list.test.tsx
Outdated
Show resolved
Hide resolved
...rprise_search/public/applications/app_search/components/credentials/credentials_list/key.tsx
Outdated
Show resolved
Hide resolved
+ minor var naming specificity
Co-authored-by: Constance <[email protected]>
@constancecchen This is ready for a second look, ty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for the speedy changes Jason!
Some super small comments, not at all blockers. Feel free to commit suggestions from github and merge after if that's easier
...e_search/public/applications/app_search/components/credentials/credentials_list/key.test.tsx
Outdated
Show resolved
Hide resolved
...e_search/public/applications/app_search/components/credentials/credentials_list/key.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/enterprise_search/public/applications/shared/hidden_text/hidden_text.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/enterprise_search/public/applications/shared/hidden_text/hidden_text.test.tsx
Show resolved
Hide resolved
Co-authored-by: Constance <[email protected]>
@constancecchen Thanks, updates made, let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeet! FWIW approvals don't dismiss after code changes like ent-search does, so feel free to merge w/o waiting for me if you prefer 🎉
Oh rad I hadn't noticed. |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
…lout-for-warm-and-cold-tier * 'master' of github.com:elastic/kibana: (126 commits) Add cumulative sum expression function (elastic#80129) [APM] Fix link to trace (elastic#80993) Provide url rewritten in onPreRouting interceptor (elastic#80810) limit renovate to npm packages Fix bug in logs UI link (elastic#80943) [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343) [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list docs test (elastic#81080) Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067) [APM] Fix service map highlighted edge on node select (elastic#80791) Fix typo in toast, slight copy adjustment. (elastic#80843) [Security Solution] reduce optimizer limits (elastic#80997) [maps] 7.10 documentation updates (elastic#79917) [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903) [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033) Upgrade EUI to v29.5.0 (elastic#80753) [Maps] Fix layer-flash when changing style (elastic#80948) [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220) [Enterprise Search] Handle loading state on Credentials page (elastic#80035) [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979) ...
Summary
This PR introduces a new component,
HiddenText
, which allows you to toggle between real text values and an obfuscated version (with the*
character) of that same text.It uses a similar Render Props pattern to the
EuiCopy
component: https://elastic.github.io/eui/#/utilities/copyExample:
This PR replaces the plain text credential key with this new HiddenText component.
It also factors out the key display into it's own component,
Key
, for easier testing and separation.Checklist
Delete any items that are not applicable to this PR.
For maintainers