Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Catch health status error from ML #80131

Merged
merged 1 commit into from
Oct 12, 2020
Merged

[APM] Catch health status error from ML #80131

merged 1 commit into from
Oct 12, 2020

Conversation

dgieselaar
Copy link
Member

Closes #80119.

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience v7.10.0 labels Oct 12, 2020
@dgieselaar dgieselaar requested a review from a team as a code owner October 12, 2020 11:16
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

cauemarcondes
cauemarcondes approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit a6b32ab into elastic:master Oct 12, 2020
@dgieselaar dgieselaar deleted the catch-ml-error branch October 12, 2020 18:16
@dgieselaar dgieselaar mentioned this pull request Oct 12, 2020
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Oct 12, 2020
@dgieselaar
[APM] Catch health status error from ML (elastic#80131)
73b08a9 
Closes elastic#80119.
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Oct 12, 2020
@dgieselaar
[APM] Catch health status error from ML (elastic#80131)
0b4d9d3 
Closes elastic#80119.
@dgieselaar dgieselaar mentioned this pull request Oct 12, 2020
Merged
cauemarcondes pushed a commit that referenced this pull request Oct 13, 2020
@dgieselaar
[APM] Catch health status error from ML (#80131) (#80213)
4f3c306 
Closes #80119.
cauemarcondes pushed a commit that referenced this pull request Oct 13, 2020
@dgieselaar
[APM] Catch health status error from ML (#80131) (#80214)
7d9b9f7 
Closes #80119.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 13, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/cloud-dat…
fb9b70c 
…a-tier-migration

* 'master' of github.com:elastic/kibana: (34 commits)
  Line Visualization improper scaling can result in gaps elastic#79663 (elastic#80135)
  [Security Solution][Timeline] Fix SelectableTimeline search (elastic#80128)
  move field_mapping util to saved_objects plugin (elastic#79918)
  [ML] Datagrid: Ensure column content with 'boolean' schema is not capitalized (elastic#80041)
  [CI] Correctly resolve repository root for JUnit reports (elastic#80226)
  [Ingest Manager] Fix package upgrade breaking after first rollover before new data has arrived (elastic#79887)
  [Security Solution] Fix positioning of Kibana banners list inside Sec… (elastic#80124)
  add missing await to fix test (elastic#80202)
  Revert test data changed in previous commit. (elastic#79479)
  [Security Solution] [Sourcerer] Jest beef up (elastic#79907)
  Re-enable transaction duration alert story (elastic#80187)
  [npm] remove canvas dep (elastic#80185)
  [DOCS] Redirects ILM docs to Elasticsearch reference (elastic#79798)
  [APM] Catch health status error from ML (elastic#80131)
  Fix layout and remove title for add alert popover. (elastic#77633)
  [Discover] Loading spinner cleanup (elastic#79819)
  [Security Solution] [Resolver] Remove related events api (elastic#79036)
  [Ingest Manager] Remove fields from index pattern during package uninstall (elastic#80082)
  do not refetch license if signature header absents from a response (elastic#79645)
  Only send agent data for non-opentelemetry agents (elastic#79587)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/server/routes/api/nodes/register_list_route.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 13, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into task-manager/health
4f37202 
* upstream/master: (34 commits)
  Improve vis editor typings (elastic#80004)
  Line Visualization improper scaling can result in gaps elastic#79663 (elastic#80135)
  [Security Solution][Timeline] Fix SelectableTimeline search (elastic#80128)
  move field_mapping util to saved_objects plugin (elastic#79918)
  [ML] Datagrid: Ensure column content with 'boolean' schema is not capitalized (elastic#80041)
  [CI] Correctly resolve repository root for JUnit reports (elastic#80226)
  [Ingest Manager] Fix package upgrade breaking after first rollover before new data has arrived (elastic#79887)
  [Security Solution] Fix positioning of Kibana banners list inside Sec… (elastic#80124)
  add missing await to fix test (elastic#80202)
  Revert test data changed in previous commit. (elastic#79479)
  [Security Solution] [Sourcerer] Jest beef up (elastic#79907)
  Re-enable transaction duration alert story (elastic#80187)
  [npm] remove canvas dep (elastic#80185)
  [DOCS] Redirects ILM docs to Elasticsearch reference (elastic#79798)
  [APM] Catch health status error from ML (elastic#80131)
  Fix layout and remove title for add alert popover. (elastic#77633)
  [Discover] Loading spinner cleanup (elastic#79819)
  [Security Solution] [Resolver] Remove related events api (elastic#79036)
  [Ingest Manager] Remove fields from index pattern during package uninstall (elastic#80082)
  do not refetch license if signature header absents from a response (elastic#79645)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Service page doesn't open when logged with apm_read_user
5 participants
@dgieselaar @elasticmachine @kibanamachine @sorenlouv @cauemarcondes