[Security Solution] Fix positioning of Kibana banners list inside Sec… #80124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
added
bug
|
Pinging @elastic/siem (Team:SIEM) |
oatkiller
approved these changes
Oct 12, 2020
| const subPluginId = useRef<string>(''); | ||
| const { ref, height = 0 } = useThrottledResizeObserver(300); | ||
| const banners$ = overlays.banners.get$(); | ||
| const [headerFixed, setHeaderFixed] = useState<boolean>(true); | ||
| const mainPaddingTop = useMemo(() => (headerFixed ? height : 0), [headerFixed, height]); |
There was a problem hiding this comment.
Is there a need for useMemo here?
There was a problem hiding this comment.
I believe so, we don't want that prop being updated without the reason
| const mainPaddingTop = useMemo(() => (headerFixed ? height : 0), [headerFixed, height]); | ||
|
|
||
| useEffect(() => { | ||
| const subscription = banners$.subscribe((banners) => setHeaderFixed(!banners.length)); |
There was a problem hiding this comment.
So the logic is "the header is fixed when there are no banners?"
There was a problem hiding this comment.
Yes that what we decide in the zoom meeting
There was a problem hiding this comment.
A little bit more details here, only the banners coming from kibana.
| const Wrapper = styled.header` | ||
| ${({ theme }) => ` | ||
| const Wrapper = styled.header<{ $isFixed: boolean }>` | ||
| ${({ theme, $isFixed }) => ` |
There was a problem hiding this comment.
It seems like any of the React components could calculate isFixed. Why did you choose to calculate it in HomePageComponent and then pass it to Wrapper via HeaderGlobal as opposed to calculating it in Wrapper directly?
There was a problem hiding this comment.
because we need that information also to determine proper paddingTop that is being passed to Main component (pass 0 if the header is static)
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 12, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 12, 2020
patrykkopycinski
added a commit
that referenced
this pull request
Oct 13, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 13, 2020
…a-tier-migration * 'master' of github.com:elastic/kibana: (34 commits) Line Visualization improper scaling can result in gaps elastic#79663 (elastic#80135) [Security Solution][Timeline] Fix SelectableTimeline search (elastic#80128) move field_mapping util to saved_objects plugin (elastic#79918) [ML] Datagrid: Ensure column content with 'boolean' schema is not capitalized (elastic#80041) [CI] Correctly resolve repository root for JUnit reports (elastic#80226) [Ingest Manager] Fix package upgrade breaking after first rollover before new data has arrived (elastic#79887) [Security Solution] Fix positioning of Kibana banners list inside Sec… (elastic#80124) add missing await to fix test (elastic#80202) Revert test data changed in previous commit. (elastic#79479) [Security Solution] [Sourcerer] Jest beef up (elastic#79907) Re-enable transaction duration alert story (elastic#80187) [npm] remove canvas dep (elastic#80185) [DOCS] Redirects ILM docs to Elasticsearch reference (elastic#79798) [APM] Catch health status error from ML (elastic#80131) Fix layout and remove title for add alert popover. (elastic#77633) [Discover] Loading spinner cleanup (elastic#79819) [Security Solution] [Resolver] Remove related events api (elastic#79036) [Ingest Manager] Remove fields from index pattern during package uninstall (elastic#80082) do not refetch license if signature header absents from a response (elastic#79645) Only send agent data for non-opentelemetry agents (elastic#79587) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/server/routes/api/nodes/register_list_route.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 13, 2020
* upstream/master: (34 commits) Improve vis editor typings (elastic#80004) Line Visualization improper scaling can result in gaps elastic#79663 (elastic#80135) [Security Solution][Timeline] Fix SelectableTimeline search (elastic#80128) move field_mapping util to saved_objects plugin (elastic#79918) [ML] Datagrid: Ensure column content with 'boolean' schema is not capitalized (elastic#80041) [CI] Correctly resolve repository root for JUnit reports (elastic#80226) [Ingest Manager] Fix package upgrade breaking after first rollover before new data has arrived (elastic#79887) [Security Solution] Fix positioning of Kibana banners list inside Sec… (elastic#80124) add missing await to fix test (elastic#80202) Revert test data changed in previous commit. (elastic#79479) [Security Solution] [Sourcerer] Jest beef up (elastic#79907) Re-enable transaction duration alert story (elastic#80187) [npm] remove canvas dep (elastic#80185) [DOCS] Redirects ILM docs to Elasticsearch reference (elastic#79798) [APM] Catch health status error from ML (elastic#80131) Fix layout and remove title for add alert popover. (elastic#77633) [Discover] Loading spinner cleanup (elastic#79819) [Security Solution] [Resolver] Remove related events api (elastic#79036) [Ingest Manager] Remove fields from index pattern during package uninstall (elastic#80082) do not refetch license if signature header absents from a response (elastic#79645) ...
patrykkopycinski
added a commit
that referenced
this pull request
Oct 13, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urity app
Summary
Fixes #80123
We have discussed possible solutions with @XavierM and @oatkiller and we decided to make Security Header static if banners exist (as the bug is related only to the case when global Kibana banners are present)