Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix observability alerting permissions #79896

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Fix observability alerting permissions #79896

merged 2 commits into from
Oct 15, 2020

Conversation

jasonrhodes
Copy link
Member

Fixes #79890

Summary

These changes make it so that a user must be given "all" permissions to an observability feature in order to create or edit alerts for that feature (before this change, they only required "read" permission in that feature).

Now, when you try to create an alert with only "read" permissions, you get an error on create. (We should improve this experience but separate from this bug fix.

Screen Shot 2020-10-07 at 2 15 24 PM

This fix has been checked and tested for:

  • Logs alerts (Jason R)
  • Metrics alerts (Jason R)
  • APM alerts
  • Uptime alerts

@jasonrhodes jasonrhodes requested review from a team as code owners October 7, 2020 18:49
@jasonrhodes jasonrhodes self-assigned this Oct 7, 2020
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@weltenwort weltenwort added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Oct 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@sorenlouv
Copy link
Member

@jasonrhodes Are you targeting this for 7.10 or 7.11?

@sorenlouv
Copy link
Member

I can still open the alerting flyout but get an error when I try to submit. Good enough for now but worth pointing out

image

@sorenlouv sorenlouv mentioned this pull request Oct 12, 2020
Closed
justinkambic
justinkambic approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behaves as desired for Uptime alerts as well. LGTM

Note: should merge master for this, I had issues running this branch without pulling in later commits.

@jasonrhodes
Copy link
Member Author

I can still open the alerting flyout but get an error when I try to submit. Good enough for now but worth pointing out

image

Yes that’s unfortunately how it’s now working in Logs and Metrics too. Definitely need to figure out how we can handle that better in our apps now.

@jasonrhodes
Copy link
Member Author

@jasonrhodes Are you targeting this for 7.10 or 7.11?

7.10 is the plan, please let me know if anyone feels like this is risky in their own apps (cc @justinkambic )

@jasonrhodes
Copy link
Member Author

@elasticmachine merge upstream

@jasonrhodes jasonrhodes added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 15, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker self-requested a review October 15, 2020 15:43
@justinkambic
Copy link
Contributor

please let me know if anyone feels like this is risky in their own apps (cc @justinkambic )

@jasonrhodes I don't think there's any special consideration for Uptime vs. the other apps 👍

simianhacker
simianhacker approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonrhodes jasonrhodes merged commit 8f3ec3a into elastic:master Oct 15, 2020
This was referenced Oct 15, 2020
Merged
Merged
jasonrhodes added a commit to jasonrhodes/kibana that referenced this pull request Oct 15, 2020
@jasonrhodes @kibanamachine
Adjusts observability alerting perms to require "all" (elastic#79896)
982060e 
Co-authored-by: Kibana Machine <[email protected]>
jasonrhodes added a commit to jasonrhodes/kibana that referenced this pull request Oct 15, 2020
@jasonrhodes @kibanamachine
Adjusts observability alerting perms to require "all" (elastic#79896)
1f2379f 
Co-authored-by: Kibana Machine <[email protected]>
jasonrhodes added a commit that referenced this pull request Oct 15, 2020
@jasonrhodes @kibanamachine
Adjusts observability alerting perms to require "all" (#79896) (#80736)
674fcdc 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
jasonrhodes added a commit that referenced this pull request Oct 15, 2020
@jasonrhodes @kibanamachine
Adjusts observability alerting perms to require "all" (#79896) (#80735)
1d150ae 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 16, 2020
@gmmorris
Merge branch 'master' into task-manager/refactor-oversized-class
475d49d 
* master: (115 commits)
  [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618)
  added brace import to vis editor (elastic#80652)
  Fix error rate sorting in services list (elastic#80764)
  Emit info log when using custom registry URL (elastic#80768)
  [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766)
  Add Storybook a11y addon (elastic#80069)
  Fix anomaly alert selection text (elastic#80746)
  [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208)
  [kbn/optimizer] tweak split chunks options (elastic#80444)
  update template to use the new team label (elastic#80748)
  [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718)
  Adjusts observability alerting perms to require "all" (elastic#79896)
  [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists   (elastic#80592)
  [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612)
  Licensed feature usage for connectors (elastic#77679)
  [Security Solution] Cypress template creation (elastic#80180)
  [APM] Hide service if only data is from ML (elastic#80145)
  Fix role mappings test for ESS (elastic#80604)
  [Maps] Add support for envelope (elastic#80614)
  [Security Solution] Update button text according to status (elastic#80389)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@simianhacker simianhacker simianhacker approved these changes

Assignees

@jasonrhodes jasonrhodes

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability Alerts] Read feature privileges grant "all" access to alerts for each observability feature
7 participants
@jasonrhodes @elasticmachine @sorenlouv @kibanamachine @justinkambic @simianhacker @weltenwort