Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] A read-only user can create alerts but not select actions #80125

Closed
sorenlouv opened this issue Oct 12, 2020 · 12 comments
Closed

[APM] A read-only user can create alerts but not select actions #80125

sorenlouv opened this issue Oct 12, 2020 · 12 comments
Assignees
Labels
Team:APM All issues that need APM UI Team support Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0

Comments

@sorenlouv
Copy link
Member

A user that only has read access to APM can create alerts via the APM app but is not able to specify an action:

This means an alert is created without actions - is this intentional?

Btw. This might be affected by #79896)

@sorenlouv sorenlouv added [zube]: Inbox Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:APM All issues that need APM UI Team support v7.10.0 labels Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Oct 12, 2020

@sqren it works for me with a user that has read permission.

Screenshot 2020-10-12 at 12 53 53

@arisonl
Copy link
Contributor

arisonl commented Oct 14, 2020

In 7.10, actions are secured separately through Kibana RBAC via the role definition view. See Actions and Connectors.

@sqren does the role have the required privileges?

@arisonl arisonl self-assigned this Oct 14, 2020
@sorenlouv
Copy link
Member Author

sorenlouv commented Oct 14, 2020

does the role have the required privileges?

No, the user does not have access to anything but APM. It therefore surprised me that I could view the flyout and create the alert, but not see or change actions.

I would expect that if I cannot see actions I shouldn't be allowed to create the alert.

@jasonrhodes
Copy link
Member

@sqren does the user really only have read permissions to APM? Based on my changes, they shouldn’t be able to create the alert at all. It should fail on submit. If they have “all” privileges for APM but not for Actions and Connectors then they should see the behavior you describe (by design).

@sorenlouv
Copy link
Member Author

Based on my changes, they shouldn’t be able to create the alert at all

This was tested before your changes made it in. Might have changed slightly after.

If they have “all” privileges for APM but not for Actions and Connectors then they should see the behavior you describe (by design).

Ok, so sounds like it still exhibits this slightly surprising behaviour after your change as well.

@sorenlouv
Copy link
Member Author

(by design).

Btw. what does that mean? that we intend for them to be able to see the flyout and create the alert but not select an action? I'm probably missing some context but what's the purpose of letting someone create an alert if they can't set actions?

@jasonrhodes
Copy link
Member

@sqren yeah I had the same questions. From @gmmorris in Slack:

Yup, this is correct and by design.

There could potentially be users who you want to allow alerting to but not actions - an analyst role for example where they should be able to investigate data but you might not want them opening a PagerDuty incident.

Longer term we’re talking about using Sub Feature controls so that it’s more granular than just “All Actions”.

@jasonrhodes
Copy link
Member

Apparently "Read" permissions to "Actions and Connectors" will allow a user to create an alert and assign it to a pre-configured Action Connector, but not create new Action Connectors. "All" permissions to A&C would allow both.

@sorenlouv
Copy link
Member Author

Thanks for the added context @jasonrhodes . I think that settles it so I'll close this issue.

@arisonl
Copy link
Contributor

arisonl commented Oct 16, 2020

Actions can be potentially leveraged by other Kibana features outside alerting. Hence they are secured separately.

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0
Projects
None yet
Development

No branches or pull requests

7 participants