Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Update help labels for web core vitals #79662

Merged
merged 7 commits into from
Oct 7, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
shahzad31 committed Oct 6, 2020
commit fac42bf7381fd521d9f19a027b8885857477a54a
Original file line number Diff line number Diff line change
@@ -48,7 +48,8 @@ export function UXMetrics() {
<KeyUXMetrics data={data} loading={status !== 'success'} />
</EuiFlexItem>
</EuiFlexGroup>
<EuiHorizontalRule />
<EuiSpacer size="xs" />
<EuiHorizontalRule margin="xs" />

<EuiFlexGroup justifyContent="spaceBetween" wrap>
<EuiFlexItem grow={1} data-cy={`client-metrics`}>
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ import { Observable } from 'rxjs';
import { CoreStart } from 'src/core/public';
import { createKibanaReactContext } from '../../../../../../../../src/plugins/kibana_react/public';
import { CoreVitalItem } from '../core_vital_item';
import { LCP_LABEL } from '../translations';
import { LCP_HELP_LABEL, LCP_LABEL } from '../translations';
import { EuiThemeProvider } from '../../../../typings';

const KibanaReactContext = createKibanaReactContext(({
@@ -40,6 +40,7 @@ export function Basic() {
title={LCP_LABEL}
value={'0.00s'}
loading={false}
helpLabel={LCP_HELP_LABEL}
/>
);
}
@@ -52,6 +53,7 @@ export function FiftyPercentGood() {
value={'0.00s'}
loading={false}
ranks={[50, 25, 25]}
helpLabel={LCP_HELP_LABEL}
/>
);
}
@@ -64,6 +66,7 @@ export function OneHundredPercentBad() {
value={'0.00s'}
loading={false}
ranks={[0, 0, 100]}
helpLabel={LCP_HELP_LABEL}
/>
);
}
@@ -76,6 +79,7 @@ export function OneHundredPercentAverage() {
value={'0.00s'}
loading={false}
ranks={[0, 100, 0]}
helpLabel={LCP_HELP_LABEL}
/>
);
}
Original file line number Diff line number Diff line change
@@ -4,14 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/

import {
EuiButtonIcon,
EuiFlexGroup,
EuiIconTip,
euiPaletteForStatus,
EuiSpacer,
EuiStat,
} from '@elastic/eui';
import { EuiFlexGroup, EuiIconTip, euiPaletteForStatus, EuiSpacer, EuiStat } from '@elastic/eui';
import React, { useState } from 'react';
import { i18n } from '@kbn/i18n';
import { PaletteLegends } from './palette_legends';