Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Update help labels for web core vitals #79662

Merged
merged 7 commits into from
Oct 7, 2020
Merged

[UX] Update help labels for web core vitals #79662

merged 7 commits into from
Oct 7, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 6, 2020 •
edited
Loading

Summary

As mentioned in #78261 Added a tooltip for core web vitals items for help

image

@shahzad31 shahzad31 marked this pull request as ready for review October 6, 2020 18:53
@shahzad31 shahzad31 requested a review from a team as a code owner October 6, 2020 18:53
@shahzad31 shahzad31 self-assigned this Oct 6, 2020
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Oct 6, 2020
@shahzad31 shahzad31 changed the title [UX] Update help label [UX] Update help labels for web core vitals Oct 6, 2020
justinkambic
justinkambic approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 4.1MB 4.1MB +123.0B

page load bundle size

id before after diff
observability 71.4KB 73.0KB +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 8f49154 into elastic:master Oct 7, 2020
@shahzad31 shahzad31 deleted the design-improvements branch October 7, 2020 08:17
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Oct 7, 2020
@shahzad31 @kibanamachine
[UX] Update help labels for web core vitals (elastic#79662)
1e3cc30 
Co-authored-by: Kibana Machine <[email protected]>
@shahzad31 shahzad31 mentioned this pull request Oct 7, 2020
Merged
shahzad31 added a commit that referenced this pull request Oct 7, 2020
@shahzad31 @kibanamachine
[UX] Update help labels for web core vitals (#79662) (#79822)
f7ca748 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@sorenlouv sorenlouv removed the Team:APM All issues that need APM UI Team support label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @elasticmachine @kibanamachine @justinkambic @sorenlouv