[cli] migrate remaining cli scripts to /dist /dev style #79409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
botelastic
bot
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
spalger
force-pushed
the
fix/cli-polyfill-prod
branch
from
93be953 to
f4a1a8a
Compare
This reverts commit f4a1a8a05247ce0023224ad5dc6828c909cd18f6.
spalger
force-pushed
the
fix/cli-polyfill-prod
branch
from
b5b6e51 to
d7fe311
Compare
spalger
removed
Team:Fleet
tylersmalley
suggested changes
Oct 5, 2020
There was a problem hiding this comment.
Since there is no more index files, we need to update the bin scripts. Otherwise:
$./bin/kibana-keystore
internal/modules/cjs/loader.js:638
throw err;
^
Error: Cannot find module '/home/tyler/test/kibana-8.0.0-SNAPSHOT-linux-x86_64/src/cli_keystore'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
at Function.Module._load (internal/modules/cjs/loader.js:562:25)
at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
tylersmalley
approved these changes
Oct 5, 2020
…ill-prod # Conflicts: # src/dev/build/tasks/copy_source_task.ts
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
spalger
pushed a commit
that referenced
this pull request
Oct 5, 2020
) Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/dev/build/tasks/copy_source_task.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79470
Fixes #79472
With #79379 we migrated to a different setup strategy for the dist and dev Kibana CLI, with the dev version loading automatic transpilation and the dist version only loading polyfills. This transition didn't make its way to the rest of the CLIs that are included in the distributable.