[babel/register] remove from build (take 2) #79379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…register-production # Conflicts: # packages/kbn-babel-preset/package.json
…register-production
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
approved these changes
Oct 2, 2020
💚 Build SucceededMetrics [docs]async chunks size
distributable file count
page load bundle size
To update your PR or re-run it, just comment with: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 2, 2020
Co-authored-by: spalger <[email protected]> # Conflicts: # package.json
spalger
pushed a commit
that referenced
this pull request
Oct 3, 2020
Co-authored-by: spalger <[email protected]> # Conflicts: # package.json Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 5, 2020
* master: (128 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to:wq! only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 5, 2020
* master: (288 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...
This was referenced Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #79176
The issue with #79176 was that the cluster manager was not updated to start the dev-specific CLI, which lived at
scripts/kibana. That CLI has now been moved tosrc/cli/devand the distributable CLI fromsrc/cli/indexhas been moved tosrc/cli/distto make the distinction more clear.Original description:
Fixes #78168
Removes babel/register from production builds of Kibana, requiring that all code loaded by Kibana runs without transformations in node.js. This has been the case for our code for a while, but is a new restriction for 3rd party plugins, which is why we want to get it in for 7.10 along with the rest of the biggest changes to the plugin system.
Dev docs
Kibana plugins can no longer rely on their server code being automatically transpiled with Babel. The
@kbn/plugin-helpersprovide a build task that will transform your plugin's server code to plain JS via Babel, but plugin authors can use any tool they like to accomplish the same result.