Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook and Jest cleanup #79305

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Storybook and Jest cleanup #79305

merged 4 commits into from
Oct 5, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 2, 2020

  • Fix all broken stories
  • Get rid of all Jest warnings
  • Remove @ts-expect-errors added for JSON imports and fix their type errors
  • Convert some stories to Component Story Format
  • Replace story for Service Map with many external services with one for the popover with many external services
  • Center and fit cytoscape maps in stories
  • Rename some files to snake_case

* Fix all broken stories
* Get rid of all Jest warnings
* Remove `@ts-expect-error`s added for JSON imports and fix their type errors
* Convert some stories to [Component Story Format](https://storybook.js.org/docs/react/api/csf)
* Replace story for Service Map with many external services with one for the popover with many external services
* Center and fit cytoscape maps in stories
* Rename some files to snake_case
@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 2, 2020
@smith smith requested review from a team as code owners October 2, 2020 15:17
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX changes LGTM !!

@smith
Copy link
Contributor Author

smith commented Oct 5, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 4.2MB 4.2MB +56.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 13a737e into elastic:master Oct 5, 2020
@smith smith deleted the nls/sb-fixes-2 branch October 5, 2020 14:18
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 5, 2020
…nes/fix-description-field

* 'master' of github.com:elastic/kibana:
  A11y tests for user page (elastic#79199)
  [Ingest Pipelines] Processors editor a11y focus states (elastic#79122)
  [Ingest pipelines] Clean up component integration tests (elastic#78838)
  Drilldowns in examples (elastic#75640)
  Storybook and Jest cleanup (elastic#79305)
  adds EQL sequence rule test (elastic#79287)
  PR template a11y checklist item improvement (elastic#79243)
  [Security Solution] Adding tests for dns pipeline in the endpoint package (elastic#79177)
  [ML] Only adjust the bounds of SMV if annotations are visible (elastic#79210)
  global search to ts refs (elastic#79446)
  [Index management] Update TemplateDeserialized interface (elastic#78913)
  [Telemetry] server fetcher check all collectors ready before sending (elastic#79398)
  [Mappings editor] Fix app crash when selecting "other" field type (elastic#79434)
  [`/api/stats`] Add documentation + small improvement (elastic#79330)
  [Discover] "View surrounding documents" encodes spaces in filters (elastic#79283)
  [Lens] refactor DimensionContainer and fix flyout bug (elastic#79277)

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/pipeline_processors_editor_item/inline_text_input.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processors_tree/components/private_tree.tsx
smith added a commit to smith/kibana that referenced this pull request Oct 5, 2020
* Fix all broken stories
* Get rid of all Jest warnings
* Remove `@ts-expect-error`s added for JSON imports and fix their type errors
* Convert some stories to [Component Story Format](https://storybook.js.org/docs/react/api/csf)
* Replace story for Service Map with many external services with one for the popover with many external services
* Center and fit cytoscape maps in stories
* Rename some files to snake_case
smith added a commit that referenced this pull request Oct 5, 2020
* Fix all broken stories
* Get rid of all Jest warnings
* Remove `@ts-expect-error`s added for JSON imports and fix their type errors
* Convert some stories to [Component Story Format](https://storybook.js.org/docs/react/api/csf)
* Replace story for Service Map with many external services with one for the popover with many external services
* Center and fit cytoscape maps in stories
* Rename some files to snake_case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants