Drilldowns in examples #75640

streamich · 2020-08-21T10:34:42Z

Summary

This PR adds developer examples of Drilldown Manager usage outside of Dashboard app.

yarn start --run-examples

go to "Developer examples" -> "UI Actions Enhanced" example plugin.

Refactors Dashboard-to-Dashboard drilldown such that it can be used in other places.
Adds example plugin for ui_actions_enhanced plugin.
"Without embeddable example" shows how Drilldown Manager could be used in a setting without embeddables and very lean trigger context, such is ML app use case.
"Without embeddable example (single button)" shows how the same button could be reused for Drilldown Manager actions as well as drilldown dynamic actions, could be useful for Canvas, if they decide to add triggers to elements.
"With embeddable example" shows that URL drilldown could be re-used in other apps if they use embeddables and VALUE_CLICK_TRIGGER.

…mples

streamich · 2020-09-29T07:54:29Z

@elasticmachine merge upstream

…mples

Dosant

Looks good,

I think removing ml / canvas reference in code is a right call, I just think we should finalise it as there are still references, for example, in trigger contexts shapes.
The example app is so nice. I'd just think we should push descriptions / displayNames / labels a bit further. I don't think anyone would get an idea that apps can register their own triggers and create there own drilldown types for those triggers by just playing with the app. For example: it is not clear that we have different "go to dashboard" implementations from example app.
Minor nit, let's at least add description?

Some other asks below. Some of them intersect with points above

x-pack/examples/ui_actions_enhanced_examples/public/plugin.ts

x-pack/examples/ui_actions_enhanced_examples/public/triggers/sample_app2_trigger.ts

x-pack/examples/ui_actions_enhanced_examples/public/triggers/sample_app1_trigger.ts

...hanced_examples/public/drilldowns/app2_to_dashboard_drilldown/app2_to_dashboard_drilldown.ts

...examples/ui_actions_enhanced_examples/public/drilldowns/dashboard_to_url_drilldown/index.tsx

...ced/public/services/drilldowns/abstract_dashboard_drilldown/abstract_dashboard_drilldown.tsx

...lldowns/components/connected_flyout_manage_drilldowns/connected_flyout_manage_drilldowns.tsx

x-pack/plugins/ui_actions_enhanced/public/drilldowns/hooks/i18n.ts

…mples

streamich · 2020-09-30T17:58:38Z

@Dosant

I've removed references, except the very deep ones inside the context object, which are not really references to ML or Canvas but just shows that the context can have app specific data.
Yes, I think for that we need to add explanations to the README, I've added explanation of what is contained in the sample folders.
I've added the description.

streamich · 2020-10-05T08:36:45Z

@elasticmachine merge upstream

Dosant

LGTM, didn't retest latest changes.
One thing: https://github.com/elastic/kibana/pull/75640/files#r498278987 (note about dashboard word in toast)
Or I guess it is fine to change in scope of #78997

kibanamachine · 2020-10-05T10:07:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3eb5e27

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`dashboardEnhanced`	26	28	+2
`discoverEnhanced`	11	10	-1
`share`	38	39	+1
`uiActionsEnhanced`	134	138	+4
total			+6

page load bundle size

id	before	after	diff
`dashboard`	570.2KB	570.3KB	+60.0B
`dashboardEnhanced`	43.1KB	49.5KB	+6.4KB
`discoverEnhanced`	29.2KB	27.1KB	-2.1KB
`share`	79.9KB	82.1KB	+2.2KB
`uiActionsEnhanced`	320.7KB	326.8KB	+6.1KB
total			+12.6KB

History

💚 Build #78616 succeeded 0c5ac3b
💔 Build #78426 failed ee6769d
💔 Build #78221 failed 8140373
💔 Build #77967 failed d04d7fc
💔 Build #77939 failed 83701c0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

majagrubic

Had a look at the code, didn't run the examples. kibana-app code looks good to me 👍
Just a few nits I noticed below 👇

x-pack/examples/ui_actions_enhanced_examples/kibana.json

...ions_enhanced/public/drilldowns/hooks/use_compatible_action_factories_for_current_context.ts

x-pack/plugins/ui_actions_enhanced/public/drilldowns/hooks/use_drilldown_state_manager.tsx

…nes/fix-description-field * 'master' of github.com:elastic/kibana: A11y tests for user page (elastic#79199) [Ingest Pipelines] Processors editor a11y focus states (elastic#79122) [Ingest pipelines] Clean up component integration tests (elastic#78838) Drilldowns in examples (elastic#75640) Storybook and Jest cleanup (elastic#79305) adds EQL sequence rule test (elastic#79287) PR template a11y checklist item improvement (elastic#79243) [Security Solution] Adding tests for dns pipeline in the endpoint package (elastic#79177) [ML] Only adjust the bounds of SMV if annotations are visible (elastic#79210) global search to ts refs (elastic#79446) [Index management] Update TemplateDeserialized interface (elastic#78913) [Telemetry] server fetcher check all collectors ready before sending (elastic#79398) [Mappings editor] Fix app crash when selecting "other" field type (elastic#79434) [`/api/stats`] Add documentation + small improvement (elastic#79330) [Discover] "View surrounding documents" encodes spaces in filters (elastic#79283) [Lens] refactor DimensionContainer and fix flyout bug (elastic#79277) # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/pipeline_processors_editor_item/inline_text_input.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processors_tree/components/private_tree.tsx

* feat: 🎸 add telemetry for in-chart "Explore underlying data" * feat: 🎸 add telemetry for in-chart "Explore underlying data" * refactor: 💡 move all drilldowns into a sub-folder * feat: 🎸 setup example app section for ui_actions_enhanced * feat: 🎸 set up Drilldown Manager section * feat: 🎸 open drilldown manager from example plugin * refactor: 💡 rename supportedTriggers -> triggers prop * feat: 🎸 show dev warning if triggers prop is empty * refactor: 💡 rename "supportedTriggers" -> "triggers" props * feat: 🎸 open and close drilldown manager from example plugin * feat: 🎸 add sample ML job trigger * feat: 🎸 add sample ML URL drilldown * refactor: 💡 move KibanaURL to share plugin * refactor: 💡 add index file to ml drilldown * feat: 🎸 add AbstractDashboardDrilldown * refactor: 💡 make dashboard drilldown use abstract drilldown * refactor: 💡 rename dashboard drilldown to embeddable drilldown * feat: 🎸 add Dashboard drilldown to sample plugin * feat: 🎸 open dashboard drilldown in list view * feat: 🎸 add drilldown execute button * refactor: 💡 move drilldown React hooks into /hooks folder * test: 💍 fix tests after renaming triggers * chore: 🤖 populate "requireBundles" * fix: 🐛 fix TypeScript errors * fix: 🐛 fix Kibana plugin dependency * chore: 🤖 remoe unused import * feat: 🎸 persist drilldown manager state across app navigations * refactor: 💡 move no-embeddable example into a seprate file * feat: 🎸 set up example with embeddable * feat: 🎸 improve embeddable example * refactor: 💡 rename without embeddable example * feat: 🎸 set up no-embeddable single click example * feat: 🎸 add dashboard drilldown to single button example * fix: 🐛 remove unused margin * fix: 🐛 make "Get more actions" translation static * chore: 🤖 remove old dashboard drilldown definition * refactor: 💡 rename samples to generic names * refactor: 💡 make app 1 example drilldown "hello world" * chore: 🤖 remove unused required bundle * chore: 🤖 add dashboardEnhanced back * [kbn/optimizer] only build xpack examples when building xpack plugins * move alerting_example into x-pack/examples * remove filter for alertingExample plugin in oss plugins CI step * revert unrelated change * fix: 🐛 use correct prop name * test: 💍 fix embeddable-to-dashboard drilldown mock * test: 💍 fix a test after refactor * chore: 🤖 remove unused import * chore: 🤖 add dashboard_enahcned to example plugin * chore: 🤖 address review comments * feat: 🎸 add description to UI Actions Enhanced examples * docs: ✏️ improve docs of example plugin Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

streamich added 30 commits August 13, 2020 12:12

feat: 🎸 add telemetry for in-chart "Explore underlying data"

ae8da5a

feat: 🎸 add telemetry for in-chart "Explore underlying data"

23f7154

Merge remote-tracking branch 'origin/master'

8e81488

refactor: 💡 move all drilldowns into a sub-folder

838425a

feat: 🎸 setup example app section for ui_actions_enhanced

8291550

feat: 🎸 set up Drilldown Manager section

bea92df

feat: 🎸 open drilldown manager from example plugin

c3933c0

refactor: 💡 rename supportedTriggers -> triggers prop

d1dd1a2

feat: 🎸 show dev warning if triggers prop is empty

1e81346

refactor: 💡 rename "supportedTriggers" -> "triggers" props

d80cce4

feat: 🎸 open and close drilldown manager from example plugin

7933266

Merge remote-tracking branch 'upstream/master' into drilldowns-in-exa…

ca46f4c

…mples

Merge remote-tracking branch 'upstream/master' into drilldowns-in-exa…

a80b461

…mples

Merge remote-tracking branch 'upstream/master' into drilldowns-in-exa…

705008d

…mples

feat: 🎸 add sample ML job trigger

0a0438c

feat: 🎸 add sample ML URL drilldown

49153c5

refactor: 💡 move KibanaURL to share plugin

2c9ddae

refactor: 💡 add index file to ml drilldown

2ce9d09

feat: 🎸 add AbstractDashboardDrilldown

664cec2

refactor: 💡 make dashboard drilldown use abstract drilldown

3da8c9b

refactor: 💡 rename dashboard drilldown to embeddable drilldown

2505558

feat: 🎸 add Dashboard drilldown to sample plugin

0e0b469

Merge remote-tracking branch 'upstream/master' into drilldowns-in-exa…

f54260b

…mples

feat: 🎸 open dashboard drilldown in list view

a64e714

feat: 🎸 add drilldown execute button

2d03893

refactor: 💡 move drilldown React hooks into /hooks folder

abf6700

test: 💍 fix tests after renaming triggers

ee9c77a

Merge remote-tracking branch 'upstream/master' into drilldowns-in-exa…

3399275

…mples

chore: 🤖 populate "requireBundles"

0c6ebb4

Merge remote-tracking branch 'upstream/master' into drilldowns-in-exa…

334e26e

…mples

elasticmachine and others added 9 commits September 29, 2020 03:54

Merge branch 'master' into drilldowns-in-examples

08dd6db

Merge remote-tracking branch 'upstream/master' into drilldowns-in-exa…

7f4b8bc

…mples

fix: 🐛 use correct prop name

be41664

test: 💍 fix embeddable-to-dashboard drilldown mock

d848d29

test: 💍 fix a test after refactor

83701c0

chore: 🤖 catch up with master

092496b

chore: 🤖 remove unused import

d04d7fc

chore: 🤖 catch up with master

9497d25

chore: 🤖 add dashboard_enahcned to example plugin

8140373

Dosant reviewed Sep 30, 2020

View reviewed changes

streamich added 4 commits September 30, 2020 16:50

Merge remote-tracking branch 'upstream/master' into drilldowns-in-exa…

a2751ef

…mples

chore: 🤖 address review comments

0343d0e

feat: 🎸 add description to UI Actions Enhanced examples

3de04fe

docs: ✏️ improve docs of example plugin

ee6769d

streamich requested a review from Dosant September 30, 2020 17:58

spalger removed the request for review from a team September 30, 2020 19:34

chore: 🤖 catch up with master

0c5ac3b

Merge branch 'master' into drilldowns-in-examples

3eb5e27

Dosant approved these changes Oct 5, 2020

View reviewed changes

majagrubic approved these changes Oct 5, 2020

View reviewed changes

streamich merged commit 59e4e06 into elastic:master Oct 5, 2020

streamich added v7.10.0 and removed v7.11.0 labels Oct 5, 2020

streamich mentioned this pull request Oct 6, 2020

[7.x] Drilldowns in examples (#75640) #79623

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drilldowns in examples #75640

Drilldowns in examples #75640

streamich commented Aug 21, 2020 •

edited

Loading

streamich commented Sep 29, 2020

Dosant left a comment

streamich commented Sep 30, 2020

streamich commented Oct 5, 2020

Dosant left a comment •

edited

Loading

kibanamachine commented Oct 5, 2020

majagrubic left a comment

Drilldowns in examples #75640

Drilldowns in examples #75640

Conversation

streamich commented Aug 21, 2020 • edited Loading

Summary

streamich commented Sep 29, 2020

Dosant left a comment

Choose a reason for hiding this comment

streamich commented Sep 30, 2020

streamich commented Oct 5, 2020

Dosant left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Oct 5, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

page load bundle size

History

majagrubic left a comment

Choose a reason for hiding this comment

streamich commented Aug 21, 2020 •

edited

Loading

Dosant left a comment •

edited

Loading