[Lens] Show runtime fields in field list and improve performance #79167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
release_note:enhancement
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
commented
Oct 1, 2020
| @@ -22,7 +22,6 @@ const fieldsWithData = [ | |||
| '@timestamp', | |||
| '_id', | |||
| '_index', | |||
| '_source', | |||
There was a problem hiding this comment.
_source was removed from the API response, but this has no effect on Lens because it was hidden anyway.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Oct 2, 2020
wylieconlon
pushed a commit
that referenced
this pull request
Oct 5, 2020
#79167) (#79340) * [Lens] Show runtime fields in field list and improve performance (#79167) * [Lens] Simplify request to determine existing fields * Remove duplicate values # Conflicts: # x-pack/test/api_integration/apis/lens/existing_fields.ts * Fix merge issue Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason runtime fields were not being shown is that their values aren't available in
_source. There was existing tech debt to move away from_sourceand towardsfields, so this PR both fixes a bug and cleans up tech debt. By usingfields, we remove the following special handling:.keywordare automatically handledAs a result, we can support field existence queries on cross-cluster search, and remove the extra calls to
mappingandfield_caps.Fixes #78171
Closes #56902
Closes #72012
Checklist