Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Improve field existence check data fetching #72012

Closed
flash1293 opened this issue Jul 16, 2020 · 2 comments · Fixed by #79167
Closed

[Lens] Improve field existence check data fetching #72012

flash1293 opened this issue Jul 16, 2020 · 2 comments · Fixed by #79167
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Project:RuntimeFields Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

See #70520

The main question here is whether we can stop making three requests for field existence, specifically the mapping request. The mapping request is used to determine that .keyword fields are multi-mapped, and we might have two ways of avoiding the need for this request:

  1. We could use the new fields request parameter, which is partially available: Search 'fields' option design + implementation elasticsearch#55363. This new API would let us skip the mapping and field_caps requests.

  2. We could skip the mapping query by adding the docvalue_fields parameter to the 500 docs search request for certain fields. There is a 100 field limit to this approach, so I think we probably can't use this in all cases.

The new fields request parameter was introduced mostly to solve this problem

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

The new fields parameter is still in a feature branch, but based on recent discussions with the ES team it sounds like it will be merged soon. I think we should hold off on making any changes until it's ready, since it's the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Project:RuntimeFields Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants