Fix tryForTime logic in removeIndexPattern

[LeeDr]

This is one part of [backport] PR #7598.

In this PR I've only changed the tryForTime logic in removeIndexPattern. Without this fix we sometimes get in the loop where we click the delete but miss the alert. Then we try to click the delete again but complain that there's an unexpected alert open.

14:17:07.040: tryForTime failure: [GET http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/alert_text] unknown error: cannot determine loading status
from unexpected alert open
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)
14:17:07.549: tryForTime failure: [POST http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/element / {"using":"css selector","value":"button.btn.btn-danger.ng-scope"}] unexpected alert open: {Alert text : Are you sure you want to remove this index pattern?}
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)
14:17:08.058: tryForTime failure: [POST http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/element / {"using":"css selector","value":"button.btn.btn-danger.ng-scope"}] unexpected alert open: {Alert text : Are you sure you want to remove this index pattern?}
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)
14:17:08.569: tryForTime failure: [POST http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/element / {"using":"css selector","value":"button.btn.btn-danger.ng-scope"}] unexpected alert open: {Alert text : Are you sure you want to remove this index pattern?}
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)
14:17:09.078: tryForTime failure: [POST http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/element / {"using":"css selector","value":"button.btn.btn-danger.ng-scope"}] unexpected alert open: {Alert text : Are you sure you want to remove this index pattern?}
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)

[LeeDr]

@Bargs please don't merge this. @ppisljar and I are debugging a failure in this area and we might need to change this PR.

[Bargs]

Good thing I procrastinated!

[epixa]

@LeeDr What's the status of this?

[LeeDr]

We resolved the immediate problem that was failing tests by updating the chromedriver version.

This logic in this change is slightly better than what's in the removeIndexPattern right now. But it would NOT have fixed the issue we were having. So I'm going to close this.

The problem with the previous chromedriver version was that clicking the delete button caused the alert to open and immediately fail on that. It was the click step itself that was throwing the exception. So we could have caught that exception, checked if it was because of the open alert, and handled it. But we don't need to now because we upgraded the chromedriver.

Closing.