-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiIcon] Update logoElasticStack
logo to latest
#7838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ I updated the changelog file in this commit to reference the correct PR, other than that looking good to me 👍
Thanks @mgadewoll 👍 |
@MichaelMarcialis Did you want to review this before merge or can we go ahead and get it in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together, @formgeist! I left a few small SVG suggestions below. If you make those, recompile the icons, and update the jest snapshots, I think this should be good to go. Approving now so I don't hold you up.
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
Thanks for the suggested changes 👍 much cleaner! |
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @formgeist |
@mgadewoll Perhaps you can do the honors of merging now that it's updated? Thanks |
`v95.1.0`⏩`v95.2.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.2.0`](https://github.com/elastic/eui/releases/v95.2.0) - Updated `EuiContextMenuItemIcon`'s type definition to explicitly define support for `EuiIcon`'s `IconType` ([#7804](elastic/eui#7804)) - Updated `EuiSteps` to support a new `titleSize="xxs"` style, which outputs the same title font size but smaller unnumbered step indicators ([#7813](elastic/eui#7813)) - Updated `EuiStepsHorizontal` to support a new `size="xs"` style, which outputs smaller unnumbered step indicators ([#7813](elastic/eui#7813)) - Updated `EuiStepNumber` to support new `titleSize="none"` which omits rendering step numbers, and will only render icons ([#7813](elastic/eui#7813)) - Updated `setEuiDevProviderWarning` to additionally accept a custom callback function, which warning messages will be passed to ([#7820](elastic/eui#7820)) - Updated `EuiIcon` to feature updated `logoElasticStack` logo for referencing Elastic Stack platform ([#7838](elastic/eui#7838)) - Updated `EuiIcon` to feature updated `casesApp` design. ([#7840](elastic/eui#7840)) - Updated `EuiComboBox` to no longer autocomplete searched text when used within forms ([#7842](elastic/eui#7842)) **CSS-in-JS conversions** - Converted `EuiFilePicker` to Emotion; Removed `$euiFilePickerTallHeight` ([#7833](elastic/eui#7833)) --------- Co-authored-by: Jon <jon@elastic.co>
Summary
Fixes #7834
Before
After
QA
Remove or strikethrough items that do not apply to your PR.
General checklist