Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Synthetics UI #77960
[Uptime] Synthetics UI #77960
Changes from all commits
6ab28e6
4cb1b54
f7e7a0c
b5e12c2
1a067d7
e1ad0a4
3807a1a
ce80357
f306d44
a0ae07e
3068243
ab26710
2674db2
d861e1a
a088ed1
b20f6cc
d3f18d1
6893024
7ee39d7
e99421f
a7b21af
bb7ff42
4558c34
67a5a85
bd015f0
f15d55b
70147a1
5c16a0d
fdb4e57
94de530
fbeba47
260a358
502d5de
941d6a9
3961507
4bb4096
c78c2e9
3d9c196
8623470
1a55db1
73a9504
18733f4
3f8b8fa
819b07e
504dfbd
2cd74ad
82af1a4
6ffecb1
4408c81
71e9e9b
cd1d813
b098917
965ceaa
955a6dd
47567f5
fc0ac9a
58579b0
783e872
ee92591
358bf81
c7caf3f
73e99bd
0579ca2
20bcf4f
35c85c8
5627814
340764d
0bb985e
09f76ad
ecc2679
7c86567
81b08a9
0be200f
bbf7449
2b707e7
f098da9
e929873
550b85f
597bbd1
29359b0
6392497
17e1d39
ca637c6
5c5287f
418bdb3
628e3a2
f4473da
5f6f325
59b6f99
486d1ec
2696683
e302a02
33ef0ad
01ace89
512ea42
a6764f2
257f13c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it makes sense to model payload this way. It's truly optional data, it should basically be
any
and consuming code would usetype
to determine which fields t check for. It's possible, for instance, for a field namedmyfield
to have different values in different docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - I will extract a type for what we're using today (I think this is basically just
step/end
) and makepayload
aoneOf([...])
case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet resolved, don't forget 😈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created elastic/uptime#258
This file was deleted.