Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper typing to Ping.Synthetics.Payload field #258

Open
justinkambic opened this issue Oct 1, 2020 · 0 comments
Open

Add proper typing to Ping.Synthetics.Payload field #258

justinkambic opened this issue Oct 1, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@justinkambic
Copy link

The Ping type as it exists has some definite assumptions about the fields it contains, but this field may contain a variety of field sets, and the same name may be used for different types depending on the document it contains.

We should instead define these types separately, and use a oneOf-style annotation.

@justinkambic justinkambic added the enhancement New feature or request label Oct 1, 2020
@justinkambic justinkambic self-assigned this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant