[ILM] Add forcemerge action to hot phase with a rollover enabled #77193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
Feature:ILM
release_note:enhancement
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@elasticmachine merge upstream |
jloleysens
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Great work @yuliacech !
Tested locally and the changes are working as expected. I left some comments about how I think we can simplify typing and I would like to get your thoughts on these but do not view them as blocking for this work.
x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx
Outdated
Show resolved
Hide resolved
...index_lifecycle_management/public/application/sections/edit_policy/components/forcemerge.tsx
Outdated
Show resolved
Hide resolved
...index_lifecycle_management/public/application/sections/edit_policy/components/forcemerge.tsx
Outdated
Show resolved
Hide resolved
...index_lifecycle_management/public/application/sections/edit_policy/components/forcemerge.tsx
Outdated
Show resolved
Hide resolved
7 tasks
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
yuliacech
added a commit
to yuliacech/kibana
that referenced
this pull request
Sep 15, 2020
…stic#77193) * [ILM] Add forcemerge action to hot phase with a rollover enabled * [ILM] Add PR suggestions Co-authored-by: Elastic Machine <[email protected]>
yuliacech
added a commit
that referenced
this pull request
Sep 15, 2020
) (#77501) * [ILM] Add forcemerge action to hot phase with a rollover enabled * [ILM] Add PR suggestions Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This was referenced Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #57642.
This PR adds a forcemerge action to hot phase of index lifecycle policy when rollover is enabled. Forcemerge is now a separate component, that can be re-used in hot and warm phases.
Screenshot
TODO
Add codec option to forcemerge.