[7.x] [ILM] Add index templates to "add policy" modal in policies table #77481
Conversation
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
cjcenizal
changed the title
There was a problem hiding this comment.
@yuliacech I started reviewing this and got halfway through, when I started to become uncomfortable with the level of changes that we're backporting for a patch release. This isn't a critical fix, and yet the amount of code being backported requires a high investment of effort to ensure we're not introducing any bugs. I don't think this level of investment is appropriate for the value provided by this backport. I think we should make things easy for ourselves, close this PR, and use the release notes to communicate to users that this fix ships with 7.10.
| @@ -29,6 +29,7 @@ export const setupEnvironment = () => { | |||
| ); | |||
|
|
|||
| mockHttpClient.interceptors.response.use(({ data }) => data); | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
Why is this necessary? It seems odd that the other changes in this PR would manifest a TS error here.
| }; | ||
|
|
||
| const renderAliasFormElement = () => { | ||
| console.log(policy); |
There was a problem hiding this comment.
Looks like a console.log snuck in here.
|
|
||
| const renderAliasFormElement = () => { | ||
| console.log(policy); | ||
| const showAliasTextInput = policy?.policy?.phases.hot?.actions.rollover; |
There was a problem hiding this comment.
The original code defines this without the first few optional chains. Do we need them or can we match the original?
const showAliasTextInput = policy.policy.phases.hot?.actions.rollover;
|
Thanks for your efforts with this code review, @cjcenizal ! I agree with you that the changes would be pretty extensive and a risk of regression bugs is high, especially since we don't have any converted TS code here. I also want to explore further UX improvements in this modal in this issue #77879 |
Summary
Backports #77077 to 7.9
Checklist
Delete any items that are not applicable to this PR.
For maintainers