Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Remove alias icon for Lens and Maps #76418

Merged
merged 4 commits into from
Sep 2, 2020
Merged

[Visualize] Remove alias icon for Lens and Maps #76418

merged 4 commits into from
Sep 2, 2020

Conversation

wylieconlon
Copy link
Contributor

Removes the icon and tooltip that would indicate that alias visualizations are not part of Visualize.

Screen Shot 2020-09-01 at 2 12 09 PM

Closes #71919

@wylieconlon wylieconlon added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.10.0 labels Sep 1, 2020
@wylieconlon wylieconlon requested a review from a team as a code owner September 1, 2020 18:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

nreese
nreese approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the alias icon.

LGTM
code reviewed, tested in chrome.

cchaos
cchaos approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
visualizations 406.9KB -472.0B 407.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra
Copy link
Contributor

mbondyra commented Sep 2, 2020

tested in FF, LGTM 👍

ppisljar
ppisljar approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@wylieconlon wylieconlon merged commit 01e4420 into elastic:master Sep 2, 2020
@wylieconlon wylieconlon deleted the remove-alias-icon branch September 2, 2020 14:34
@wylieconlon wylieconlon mentioned this pull request Sep 2, 2020
Merged
wylieconlon pushed a commit that referenced this pull request Sep 2, 2020
[Visualize] Remove alias icon for Lens and Maps (#76418) (#76514)
7e6db3f 
* [Visualize] Remove alias icon for Lens and Maps

* Fix snapshots

* Fix translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@mbondyra mbondyra mbondyra approved these changes

@cchaos cchaos cchaos approved these changes

@nreese nreese nreese approved these changes

@ryankeairns ryankeairns Awaiting requested review from ryankeairns

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove visual distinction between alias visualizations and visualizations when creating a new visualization
7 participants
@wylieconlon @elasticmachine @kibanamachine @mbondyra @nreese @cchaos @ppisljar