Skip to content

Commit

Permalink
[Visualize] Remove alias icon for Lens and Maps (#76418)
Browse files Browse the repository at this point in the history
* [Visualize] Remove alias icon for Lens and Maps

* Fix snapshots

* Fix translations
  • Loading branch information
Wylie Conlon authored Sep 2, 2020
1 parent 3e07797 commit 01e4420
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 170 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -221,36 +221,18 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
defaultMessage:
'This visualization is experimental. The design and implementation are less mature than stable visualizations and might be subject to change.',
});
} else if ('aliasPath' in visType) {
if (visType.stage === 'beta') {
const aliasDescription = i18n.translate('visualizations.newVisWizard.betaDescription', {
defaultMessage:
'This visualization is in beta and is subject to change. The design and code is less mature than official GA features and is being provided as-is with no warranties. Beta features are not subject to the support SLA of official GA features',
});
stage = {
betaBadgeLabel: i18n.translate('visualizations.newVisWizard.betaTitle', {
defaultMessage: 'Beta',
}),
betaBadgeTooltipContent: aliasDescription,
// betaBadgeIconType: 'popout',
};
highlightMsg = aliasDescription;
} else {
const aliasDescription = i18n.translate(
'visualizations.newVisWizard.visTypeAliasDescription',
{
defaultMessage: 'Opens a Kibana application that is outside of Visualize.',
}
);
stage = {
betaBadgeLabel: i18n.translate('visualizations.newVisWizard.visTypeAliasTitle', {
defaultMessage: 'Kibana application',
}),
betaBadgeTooltipContent: aliasDescription,
betaBadgeIconType: 'popout',
};
highlightMsg = aliasDescription;
}
} else if ('aliasPath' in visType && visType.stage === 'beta') {
const aliasDescription = i18n.translate('visualizations.newVisWizard.betaDescription', {
defaultMessage:
'This visualization is in beta and is subject to change. The design and code is less mature than official GA features and is being provided as-is with no warranties. Beta features are not subject to the support SLA of official GA features',
});
stage = {
betaBadgeLabel: i18n.translate('visualizations.newVisWizard.betaTitle', {
defaultMessage: 'Beta',
}),
betaBadgeTooltipContent: aliasDescription,
};
highlightMsg = aliasDescription;
}

const isDisabled = this.state.query !== '' && !visType.highlighted;
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -4433,8 +4433,6 @@
"visualizations.newVisWizard.searchSelection.savedObjectType.search": "保存検索",
"visualizations.newVisWizard.selectVisType": "ビジュアライゼーションのタイプを選択してください",
"visualizations.newVisWizard.title": "新規ビジュアライゼーション",
"visualizations.newVisWizard.visTypeAliasDescription": "Visualize 外で Kibana アプリケーションを開きます。",
"visualizations.newVisWizard.visTypeAliasTitle": "Kibana アプリケーション",
"visualizations.savedObjectName": "ビジュアライゼーション",
"visualizations.visualizationTypeInvalidMessage": "無効なビジュアライゼーションタイプ \"{visType}\"",
"visualize.badge.readOnly.text": "読み取り専用",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -4434,8 +4434,6 @@
"visualizations.newVisWizard.searchSelection.savedObjectType.search": "已保存搜索",
"visualizations.newVisWizard.selectVisType": "选择可视化类型",
"visualizations.newVisWizard.title": "新建可视化",
"visualizations.newVisWizard.visTypeAliasDescription": "打开 Visualize 外部的 Kibana 应用程序。",
"visualizations.newVisWizard.visTypeAliasTitle": "Kibana 应用程序",
"visualizations.savedObjectName": "可视化",
"visualizations.visualizationTypeInvalidMessage": "无效的可视化类型“{visType}”",
"visualize.badge.readOnly.text": "只读",
Expand Down

0 comments on commit 01e4420

Please sign in to comment.