Legacy ES plugin pre-removal cleanup #75779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Feature:Legacy Removal
…-plugin-pre-removal
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
reviewed
Aug 26, 2020
|
|
||
| export default function (kibana) { | ||
| let defaultVars; | ||
|
|
||
| return new kibana.Plugin({ | ||
| require: ['kibana'], | ||
| require: [], |
There was a problem hiding this comment.
Wouldn't it affect an execution order?
There was a problem hiding this comment.
Yea, the kibana legacy plugin is no longer assured to be initialized before the es one. However as the kibana plugin is an empty shell now, this shouldn't have any consequences (and is preparing the actual removal of the kibana plugin)
mshustov
reviewed
Aug 26, 2020
| @@ -523,6 +523,4 @@ export interface CallCluster { | |||
| export interface ElasticsearchPlugin { | |||
| status: { on: (status: string, cb: () => void) => void }; | |||
| getCluster(name: string): Cluster; | |||
| createCluster(name: string, config: ClusterConfig): Cluster; | |||
| waitUntilReady(): Promise<void>; | |||
There was a problem hiding this comment.
let's remove this comment as well
mshustov
approved these changes
Aug 26, 2020
|
retest |
💚 Build SucceededBuild metricsoss distributable file count
distributable file count
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Aug 26, 2020
* delete integration tests * remove legacy version healthcheck / waitUntilReady * remove handleESError * remove createCluster * no longer depends on kibana plugin * fix kbn_server * remove deprecated comment and dead code * revert code removal, apparently was used (?) * Revert "revert code removal, apparently was used (?)" This reverts commit 6948185 # Conflicts: # src/legacy/core_plugins/elasticsearch/index.js # src/legacy/core_plugins/elasticsearch/lib/__tests__/handle_es_error.js # src/legacy/core_plugins/elasticsearch/lib/handle_es_error.js
pgayvallet
added a commit
that referenced
this pull request
Aug 27, 2020
* delete integration tests * remove legacy version healthcheck / waitUntilReady * remove handleESError * remove createCluster * no longer depends on kibana plugin * fix kbn_server * remove deprecated comment and dead code * revert code removal, apparently was used (?) * Revert "revert code removal, apparently was used (?)" This reverts commit 6948185 # Conflicts: # src/legacy/core_plugins/elasticsearch/index.js # src/legacy/core_plugins/elasticsearch/lib/__tests__/handle_es_error.js # src/legacy/core_plugins/elasticsearch/lib/handle_es_error.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #71927
Remove all the dead parts of the legacy ES plugin, only keeping the 'proxy' / endpoints that are still used until #73993 and #73992 are addressed.