-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace usage of /elasticsearch/_msearch
endpoint in tutorials
#73992
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
Pinging @elastic/kibana-core-ui (Team:Core UI) |
@joshdover Can you provide any further detail on what exactly needs to happen? That will allows us to better determine when we could possibly fit this in. Michael and Catherine are both working on high priority items for 7.10 (new header + search; home + landing pages), so I'm not sure if/when they'd be available. |
The backend endpoint What needs to happen is that the code I linked to above needs to be calling a backend route that exists in the same plugin (home) and only exposes the minimum needed feature set to support whatever the UI does with that endpoint. If we get to the point where this is the last blocker, the Platform team can help with this. Any investigation that could be done prior to Platform picking this up would be helpful. In particular, I think we just need to know what exactly this endpoint is being used for so we can provide an API that is narrower in scope rather than providing the entire ES search API. |
Thanks, that helps. I'll bring it up at our sync tomorrow. |
Did some digging into what On tutorial pages (such as at home#/tutorial/apm) there are various "check status" type buttons. Each tutorial sets their own config of what indexes to query and what the query config is. The response is then used to to notify the user of the status (error, no data, has data). The exact data, how much of it, etc isn't ever used. There seems to only be 8 uses of this. You can see all the configs here: https://github.com/elastic/kibana/search?l=TypeScript&q=esHitsCheck%3A+%7B |
In order to unblock removing legacy plugin support (#71927) we need to remove all usages of the
/elasticsearch/_msearch
endpoint. This can be replaced with a specific endpoint in thehome
plugin that provides only the needed functionality for the frontend.kibana/src/plugins/home/public/application/components/tutorial/tutorial.js
Line 206 in 4eb455d
The text was updated successfully, but these errors were encountered: