Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - fix imports in results API tests #75533

Merged
merged 1 commit into from
Aug 20, 2020
Merged

[ML] Functional tests - fix imports in results API tests #75533

merged 1 commit into from
Aug 20, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Aug 20, 2020 •
edited
Loading

Summary

This PR fixes the broken COMMON_REQUEST_HEADERS in the recently added results API tests.

Details

There have been conflicting merges of #75307 and #75061.

@pheyos pheyos self-assigned this Aug 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos added the release_note:skip Skip the PR/issue when compiling release notes label Aug 20, 2020
walterra
walterra approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darnautov
darnautov approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 77a434b into elastic:master Aug 20, 2020
@pheyos pheyos deleted the fix_api_imports branch August 20, 2020 10:38
@pheyos pheyos mentioned this pull request Aug 20, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Aug 20, 2020
@pheyos
[ML] Functional tests - fix imports in results API tests (elastic#75533)
cfc4d29 
This PR fixes the broken COMMON_REQUEST_HEADERS in the recently added results API tests.

(cherry picked from commit 77a434b)
@pheyos
Copy link
Member Author

pheyos commented Aug 20, 2020

The 7.x backport is done as part of #75529

pheyos added a commit that referenced this pull request Aug 20, 2020
@pheyos
[7.x] [ML] Functional tests - refactor structure of ML and Transform …
7d167b6 
…test files (#75307) (#75529)

* [ML] Functional tests - refactor structure of ML and Transform test files (#75307)

This PR refactors the structure of ML and Transform functional UI test files.

* [ML] Functional tests - fix imports in results API tests (#75533)

This PR fixes the broken COMMON_REQUEST_HEADERS in the recently added results API tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@walterra walterra walterra approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pheyos @elasticmachine @kibanamachine @walterra @darnautov