[ML] Functional tests - refactor structure of ML and Transform test files #75307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
:ml
test_ui_functional
v8.0.0
release_note:skip
pheyos
requested review from
walterra,
darnautov,
alvarezmelissa87,
peteharverson,
jgowdyelastic and
qn895
|
Pinging @elastic/ml-ui (:ml) |
|
Checking test stability in flaky test runner jobs:
|
peteharverson
approved these changes
Aug 19, 2020
qn895
approved these changes
Aug 19, 2020
|
LGTM 💯 |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Aug 20, 2020
…iles (elastic#75307) This PR refactors the structure of ML and Transform functional UI test files.
pheyos
added a commit
that referenced
this pull request
Aug 20, 2020
…test files (#75307) (#75529) * [ML] Functional tests - refactor structure of ML and Transform test files (#75307) This PR refactors the structure of ML and Transform functional UI test files. * [ML] Functional tests - fix imports in results API tests (#75533) This PR fixes the broken COMMON_REQUEST_HEADERS in the recently added results API tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the structure of ML and Transform functional UI test files.
Details
This is mainly about not having a test (via
it) for actions that are rather a test step, but make the tests be a high level item that can potentially contain many test steps. That way the test files are better structured and easier to maintain. The tests inside a suite can still be dependent on each other, i.e. if the first test fails, the second one is likely to fail as well as some prerequisite isn't met.In the past, we used many tests to get more visibility for where a test failure occurred (particularly interesting in longer workflow tests). Since there's no test step support available in the test framework but we still don't want to lose the ability to quickly track down the failure step, a new test step logging is introduced with this PR via
testExecution.logTestStep(available in themland thetransformservice). For starters, this just takes over eachittitle and logs it as a test step. A few new high levelitentries have been added.One example for the new test structure:
Note: More changes are planned for the future, e.g. separating out some of the clone, edit and delete tests to their own test files.
Other changes
A few more small refactorings are also part of this PR:
!notationml.commonintoml.common_uiandml.common_apicombobox.setCustom(which is designed to add new entries like in our job group input) tocombobox.set(which should be used to pick an existing entry from the list).