Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log dependency path info in licenses grunt task. #7527

Merged
merged 1 commit into from
Jun 22, 2016
Merged

Log dependency path info in licenses grunt task. #7527

merged 1 commit into from
Jun 22, 2016

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jun 21, 2016 •
edited
Loading

Split from #7515

Changes

  • Log dependency path info in licenses grunt task. Now you'll see a path of the parent dependencies when a dependency fails to licenses task, so you can identify the offending root dependency.
  • ES2015ify the licenses task.

How to test

  • Install a version of NPM that causes the license-checker to "not find" a license: npm i [email protected]
  • Run the licenses task: grunt licenses

You should get this warning:

Warning: Non-confirming licenses:
 [email protected] / [email protected] / fsevents@>=1.0.0 <2.0.0 / [email protected] / nopt@~3.0.1 / abbrev@1 Use --force to continue.

@cjcenizal cjcenizal force-pushed the improvement/licenses-task-log-path branch 4 times, most recently from c6fad15 to 251eb6d Compare June 21, 2016 19:04
@cjcenizal cjcenizal force-pushed the improvement/licenses-task-log-path branch from 251eb6d to 2c9c595 Compare June 21, 2016 19:06
@spalger
Copy link
Contributor

spalger commented Jun 22, 2016

LGTM

@cjcenizal
Log dependency path info in licenses grunt task.
6d6ab4a 
- Now you'll see a path of the parent dependencies when a dependency fails to licenses task, so you can identify the offending root dependency.
- ES2015ify the licenses task.
@cjcenizal cjcenizal force-pushed the improvement/licenses-task-log-path branch from 2c9c595 to 6d6ab4a Compare June 22, 2016 01:56
@cjcenizal cjcenizal merged commit ded0ee0 into elastic:master Jun 22, 2016
@cjcenizal cjcenizal deleted the improvement/licenses-task-log-path branch June 22, 2016 03:06
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
@cjcenizal
Merge pull request elastic#7527 from cjcenizal/improvement/licenses-t…
66dacb4 
…ask-log-path

Log dependency path info in licenses grunt task.

Former-commit-id: ded0ee0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spalger spalger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcenizal @spalger