-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move visualRegression subtask from npm scripts to grunt task. #7515
Move visualRegression subtask from npm scripts to grunt task. #7515
Conversation
@@ -32,6 +32,7 @@ module.exports = function (grunt) { | |||
'UNLICENSE' | |||
], | |||
overrides: { | |||
'[email protected]': ['MIT'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's based on the package having a license in an undiscoverable format. Like, if it's mentioned in the README somewhere, or in a github issue, the license discovery tool won't be able to detect it automatically so we hard code it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not even sure if this is the right way to handle this... I tried to figure out the root cause of the problem (since this is only happening to me apparently), but gave up and figured it's better to just sidestep it and move forward. 😠 Should I go back and work this bug over instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also just realized the license is ISC, not MIT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency path tracing is very cool! Correct me if I'm wrong but it seems unrelated to the change of moving |
abb021f
to
27c0ccd
Compare
@cjcenizal I looked into this a bit more and updating our npm dependency does seem to fix the license check issue. Can we open a separate PR to update npm to 2.15.1(and close #7184) and keep this PR for moving npm scripts? |
- Add it to end of test grunt task.
27c0ccd
to
ca9b085
Compare
…n-subtask Move visualRegression subtask from npm scripts to grunt task. Former-commit-id: 5caa6c0
This PR supersedes #7461.
Changes
Log dependency path info in licenses grunt task. Now you'll see a path of the parent dependencies when a dependency fails to licenses task, so you can identify the offending root dependency.ES2015ify the licenses task.Add an override for [email protected] because the licenses task was failing for that dependency, even though it has the MIT license.