Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Logs UI] Remove apollo deps from log link-to routes (#74502) #75071

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

weltenwort
Copy link
Member

Backports the following commits to 7.x:

This replaces the use of the old graphql-based `useSource` hook with the new plain JSON `useLogSource` hook.

It also fixes two more problems:

- A rendering problem with the source configuration loading screen and a `setState` race condition in the `useLogSource` hook.
- A non-backwards-compatible change of the `/link-to/:sourceId/logs` route in elastic#61162.
@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@weltenwort weltenwort self-assigned this Aug 17, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
infra 1087 +30 1057

async chunks size

id value diff baseline
infra 3.5MB +38.1KB 3.5MB

page load bundle size

id value diff baseline
infra 275.5KB +61.0B 275.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@weltenwort weltenwort merged commit 3fcedaa into elastic:7.x Aug 17, 2020
@weltenwort weltenwort deleted the backport/7.x/pr-74502 branch August 17, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants