[Logs / Metrics UI] [NP followup] Cleanup link-to routes #61162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Zacqary
added
the
release_note:skip
afgomez
approved these changes
Mar 25, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Mar 27, 2020
* Split link-to into Metrics and Logs routers * Fix logs stream link-to * Import fix * Update snapshots Co-authored-by: Elastic Machine <[email protected]>
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Aug 11, 2020
This was removed in a non-backwards-compatible way in elastic#61162.
This was referenced Aug 11, 2020
weltenwort
added a commit
that referenced
this pull request
Aug 14, 2020
This replaces the use of the old graphql-based `useSource` hook with the new plain JSON `useLogSource` hook. It also fixes two more problems: - A rendering problem with the source configuration loading screen and a `setState` race condition in the `useLogSource` hook. - A non-backwards-compatible change of the `/link-to/:sourceId/logs` route in #61162.
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Aug 14, 2020
This replaces the use of the old graphql-based `useSource` hook with the new plain JSON `useLogSource` hook. It also fixes two more problems: - A rendering problem with the source configuration loading screen and a `setState` race condition in the `useLogSource` hook. - A non-backwards-compatible change of the `/link-to/:sourceId/logs` route in elastic#61162.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58005
Cleans up
link-toroutes, removes Logs-relevant routes from Metrics and vice-versa, fixes alink-tobug related to the new Logs schema withstartandendparamsChecklist