Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy spaces plugin #74532

Merged
merged 6 commits into from
Sep 18, 2020
Merged

Remove legacy spaces plugin #74532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
383b7bf
Remove legacy spaces plugin
legrego Aug 6, 2020
a99cce0
Merge branch 'master' of github.com:elastic/kibana into spaces/remove…
legrego Sep 17, 2020
5cf4614
remove legacy spaces plugin from CODEOWNERS
legrego Sep 17, 2020
d8a9bae
Merge branch 'master' of github.com:elastic/kibana into spaces/remove…
legrego Sep 17, 2020
eff152c
remove more references to the legacy spaces plugin
legrego Sep 17, 2020
32a4971
Merge branch 'master' of github.com:elastic/kibana into spaces/remove…
legrego Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@

# Security
/src/core/server/csp/ @elastic/kibana-security @elastic/kibana-platform
/x-pack/legacy/plugins/spaces/ @elastic/kibana-security
/x-pack/plugins/spaces/ @elastic/kibana-security
/x-pack/plugins/encrypted_saved_objects/ @elastic/kibana-security
/x-pack/plugins/security/ @elastic/kibana-security
Expand Down Expand Up @@ -281,7 +280,6 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
# Core design
/src/plugins/dashboard/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/plugins/canvas/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/legacy/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
/x-pack/plugins/security/**/*.scss @elastic/kibana-core-ui-designers

Expand Down
2 changes: 1 addition & 1 deletion src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion x-pack/.i18nrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"xpack.server": "legacy/server",
"xpack.securitySolution": "plugins/security_solution",
"xpack.snapshotRestore": "plugins/snapshot_restore",
"xpack.spaces": ["legacy/plugins/spaces", "plugins/spaces"],
"xpack.spaces": "plugins/spaces",
"xpack.taskManager": "legacy/plugins/task_manager",
"xpack.transform": "plugins/transform",
"xpack.triggersActionsUI": "plugins/triggers_actions_ui",
Expand Down
3 changes: 1 addition & 2 deletions x-pack/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
*/

import { xpackMain } from './legacy/plugins/xpack_main';
import { spaces } from './legacy/plugins/spaces';

module.exports = function (kibana) {
return [xpackMain(kibana), spaces(kibana)];
return [xpackMain(kibana)];
};
83 changes: 0 additions & 83 deletions x-pack/legacy/plugins/spaces/index.ts
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions x-pack/legacy/plugins/spaces/server/lib/errors.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion x-pack/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"kibana/public": ["src/core/public"],
"kibana/server": ["src/core/server"],
"plugins/xpack_main/*": ["x-pack/legacy/plugins/xpack_main/public/*"],
"plugins/spaces/*": ["x-pack/legacy/plugins/spaces/public/*"],
"test_utils/*": ["x-pack/test_utils/*"],
"fixtures/*": ["src/fixtures/*"]
},
Expand Down