Remove legacy spaces plugin

[legrego]

Summary

Removes the legacy spaces plugin 🎉

Blocked on #41983

[elasticmachine]

Pinging @elastic/kibana-security (Team:Security)

[legrego]

@spalger tagging you since I remember you worked on this about a year ago. This PR is failing because @kbn/es-archiver relies on the legacy status api to figure out of spaces is enabled, and removing the legacy spaces plugin causes these checks to return false instead of true:

kibana/packages/kbn-es-archiver/src/lib/indices/kibana_index.ts

Line 104 in 9655c87

if (!kibanaPluginIds.includes('spaces')) {

I know the status API hasn't been migrated yet, but are you aware of anything else we can use in the interim to make this determination?

[spalger]

Well, we could try always behaving like spaces are enabled, but I would rather not make changes to that logic without more careful consideration and there is a lot to consider... I would prefer that we finish the status API migration first but I'm not sure what the timeline is on that. @elastic/kibana-platform?

[joshdover]

I would prefer that we finish the status API migration first but I'm not sure what the timeline is on that. @elastic/kibana-platform?

It's our roadmap for 7.10. I may be able to focus on that next week, but may also be pulled into some other unrelated scaling tasks. I think we're ok to leave this PR open for a while and we can merge it once #41983 is completed.

[legrego]

Test flakiness appears unrelated to this PR

[jportner]

I found a couple other references to "legacy/plugins/spaces" in x-pack/tsconfig.json, x-pack/.i18nrc.json, .github/CODEOWNERS, and src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json, could you remove those too?

[legrego]

I found a couple other references to "legacy/plugins/spaces" in x-pack/tsconfig.json, x-pack/.i18nrc.json, .github/CODEOWNERS, and src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json, could you remove those too?

Wow, thanks! My code searching skills are not up to par lately

[jportner]

LGTM! 😀

[wayneseymour]

src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json will be removed soon, fyi :)

[legrego]

src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json will be removed soon, fyi :)

@wayneseymour that's great! Are you suggesting that I revert the change since it's going away, or is the change OK from your perspective?

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 32a4971

Build metrics

distributable file count

id	value	diff	baseline
default	45919	-2	45921

History

• 💚 Build #75339 succeeded eff152c
• 💛 Build #75269 was flaky d8a9bae
• 💚 Build #75228 succeeded 5cf4614
• 💚 Build #75188 succeeded a99cce0
• 💔 Build #66915 failed 383b7bf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[wayneseymour]

src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json will be removed soon, fyi :)

@wayneseymour that's great! Are you suggesting that I revert the change since it's going away, or is the change OK from your perspective?

Honestly, either way is fine, imho. @LeeDr ?

[legrego]

Since it's not impacting CI from what I can tell, I'll merge as-is to unblock the Platform team. Let me know if you'd like that reverted and I'll be happy to do so.