Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Lists] - Tests cleanup and remove unnecessary import #73865

Merged
merged 2 commits into from
Jul 30, 2020
Merged

[Security Solution][Lists] - Tests cleanup and remove unnecessary import #73865

merged 2 commits into from
Jul 30, 2020

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jul 30, 2020 •
edited
Loading

Summary

Addresses feedback from #72748

  • Updates plugins/lists tests text from should not validate to should FAIL validation after feedback that previous text is a bit confusing and can be interpreted to mean that validation is not conducted
  • Remove unnecessary spreads from one of my late night PRs 🧟‍♀️
  • Removes siem_common_deps in favor of shared_imports in plugins/lists
  • Updates build_exceptions_query.test.ts to use existing mocks

Checklist

@yctercero yctercero self-assigned this Jul 30, 2020
@yctercero yctercero added Team:SIEM v7.10.0 v7.9.1 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 30, 2020
@yctercero yctercero mentioned this pull request Jul 30, 2020
Merged
6 tasks
@yctercero yctercero marked this pull request as ready for review July 30, 2020 21:08
@yctercero yctercero requested review from a team as code owners July 30, 2020 21:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

rylnd
rylnd approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice straightforward cleanup. Thanks!

x-pack/plugins/security_solution/common/detection_engine/build_exceptions_query.test.ts
@@ -137,14 +64,14 @@ describe('build_exceptions_query', () => {
describe('kuery', () => {
test('it returns formatted wildcard string when operator is "excluded"', () => {
const query = buildExists({
entry: existsEntryWithExcluded,
entry: { ...getEntryExistsMock(), operator: 'excluded' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like the named constants in the general case to help answer "what does this object represent?" but in this case that's mostly redundant with the test description 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
lists 122 -1 123

page load bundle size

id value diff baseline
lists 269.5KB -489.0B 270.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit 84884a9 into elastic:master Jul 30, 2020
yctercero added a commit to yctercero/kibana that referenced this pull request Jul 30, 2020
@yctercero
[Security Solution][Lists] - Tests cleanup and remove unnecessary imp…
1cf30bb 
…ort (elastic#73865)

## Summary

Addresses feedback from elastic#72748

- Updates `plugins/lists` tests text from `should not validate` to `should FAIL validation` after feedback that previous text is a bit confusing and can be interpreted to mean that validation is not conducted
- Remove unnecessary spreads from one of my late night PRs
- Removes `siem_common_deps` in favor of `shared_imports` in `plugins/lists`
- Updates `build_exceptions_query.test.ts` to use existing mocks
@yctercero yctercero mentioned this pull request Jul 30, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 31, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
28b1676 
* master: (54 commits)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  [Security Solution][Detections] Change from sha1 to sha256 (elastic#73741)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 31, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
ce2ee00 
* master: (38 commits)
  [Discover] Context unskip date nanos functional tests (elastic#73781)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  ...
yctercero added a commit that referenced this pull request Jul 31, 2020
@yctercero
[Security Solution][Lists] - Tests cleanup and remove unnecessary imp…
f257c88 
…ort (#73865) (#73905)

## Summary

Addresses feedback from #72748

- Updates `plugins/lists` tests text from `should not validate` to `should FAIL validation` after feedback that previous text is a bit confusing and can be interpreted to mean that validation is not conducted
- Remove unnecessary spreads from one of my late night PRs
- Removes `siem_common_deps` in favor of `shared_imports` in `plugins/lists`
- Updates `build_exceptions_query.test.ts` to use existing mocks
@yctercero yctercero deleted the exceptions_cleanup branch October 14, 2020 11:59
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

@madirey madirey madirey approved these changes

Assignees

@yctercero yctercero

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yctercero @elasticmachine @kibanamachine @madirey @rylnd @MindyRS