[Discover] Improve saveSearch functional test handling #73626

kertal · 2020-07-29T05:39:10Z

Summary

Improve functional test saveSearch method to prevent occasional flakiness, when a search name wasn't inserted and the persisting hasn't started therefore.

Fixes #68706

https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/62931/console

Here's the flaky test runner to be sure, no errors reported:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/702/testReport/Chrome%20X-Pack%20UI%20Functional%20Tests/x-pack_test_functional_apps_discover_reporting·ts/

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-07-29T08:53:53Z

Pinging @elastic/kibana-app (Team:KibanaApp)

dmlemeshko · 2020-07-29T10:53:03Z

test/functional/page_objects/discover_page.ts

+      await retry.waitFor(`saved search can be persisted name ${searchName}`, async () => {
+        await testSubjects.setValue('savedObjectTitle', searchName);
+        await testSubjects.click('confirmSaveSavedObjectButton');
+        return (await header.isGlobalLoadingIndicatorVisible()) === true;


I thought we might need to wait for popup to disappear
return (await testSubjects.exists('confirmSaveSavedObjectButton', { timeout: 5000 })) === false

Is there a chance that popup will remain in place and header.isGlobalLoadingIndicatorVisible() will return true ?

good point 👍 , I will take a closer look here!

I'm wondering if we can always catch the loading indicator after clicking save. Could it be that in some cases the save is quick enough that we never see the loading indicator?

Also, if we do find the loading indicator, I think we should then wait for it to be hidden before returning from saveSearch method. I think waitUntilLoadingHasFinished was doing that.

I've changed the code to check for the save button not to be disabled, this should catch the occasional
flakiness when for whatever reason the title wasn't entered, and the save button stayed disabled therefore

flaky test runner says, it's ok this way: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/712/

…-29-improve-discover-page-functional

kibanamachine · 2020-07-30T08:30:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 460d294

Build metrics

✅ unchanged

History

💚 Build #65105 succeeded 01e399a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dmlemeshko

LGTM

LeeDr

LGTM - thanks for working on this! I didn't pull code and test. Only code review and Jenkins results.

* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness

* master: (54 commits) [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941) [Discover] Improve saveSearch functional test handling (elastic#73626) [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708) [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735) [SIEM] Fixes "include building block button" to operate (elastic#73900) [Metrics UI] Fix alert management to open without refresh (elastic#73739) [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865) [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555) [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867) [Maps] upgrade turf (elastic#73816) [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558) [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745) [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761) [Metrics UI] Fix previewing of No Data results (elastic#73753) Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638) [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833) [DOCS] Fixes typo in Alerting actions (elastic#73756) [APM] fixes linking errors to ML and Discover (elastic#73758) Handle promise rejections when building artifacts (elastic#73831) [Security Solution][Detections] Change from sha1 to sha256 (elastic#73741) ...

* master: (38 commits) [Discover] Context unskip date nanos functional tests (elastic#73781) [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941) [Discover] Improve saveSearch functional test handling (elastic#73626) [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708) [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735) [SIEM] Fixes "include building block button" to operate (elastic#73900) [Metrics UI] Fix alert management to open without refresh (elastic#73739) [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865) [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555) [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867) [Maps] upgrade turf (elastic#73816) [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558) [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745) [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761) [Metrics UI] Fix previewing of No Data results (elastic#73753) Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638) [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833) [DOCS] Fixes typo in Alerting actions (elastic#73756) [APM] fixes linking errors to ML and Discover (elastic#73758) Handle promise rejections when building artifacts (elastic#73831) ...

Improve discover saveSearch functional test handling

01e399a

kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v6.8.2 v7.10.0 v7.9.0 labels Jul 29, 2020

kertal self-assigned this Jul 29, 2020

kertal removed the v6.8.2 label Jul 29, 2020

kertal requested review from LeeDr and dmlemeshko July 29, 2020 08:53

kertal marked this pull request as ready for review July 29, 2020 08:53

dmlemeshko reviewed Jul 29, 2020

View reviewed changes

kertal added 2 commits July 30, 2020 07:58

Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-07…

313f794

…-29-improve-discover-page-functional

Check for submit button to be disabled

460d294

kertal requested a review from dmlemeshko July 30, 2020 06:46

dmlemeshko approved these changes Jul 30, 2020

View reviewed changes

LeeDr approved these changes Jul 30, 2020

View reviewed changes

kertal merged commit 39cca0e into elastic:master Jul 31, 2020

kertal mentioned this pull request Jul 31, 2020

[7.x] [Discover] Improve saveSearch functional test handling (#73626) #73915

Merged

kertal added a commit to kertal/kibana that referenced this pull request Jul 31, 2020

[Discover] Improve saveSearch functional test handling (elastic#73626)

98a3078

* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness

kertal added a commit to kertal/kibana that referenced this pull request Jul 31, 2020

[Discover] Improve saveSearch functional test handling (elastic#73626)

c1a8bc2

* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness

kertal mentioned this pull request Jul 31, 2020

[7.9] [Discover] Improve saveSearch functional test handling (#73626) #73916

Merged

kertal added a commit that referenced this pull request Jul 31, 2020

[Discover] Improve saveSearch functional test handling (#73626) (#73915)

8be822b

* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness

kertal added a commit that referenced this pull request Jul 31, 2020

[Discover] Improve saveSearch functional test handling (#73626) (#73916)

26d6a31

* Check for submit button to be disabled, before submitting the form to prevent occasional flakiness

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Improve saveSearch functional test handling #73626

[Discover] Improve saveSearch functional test handling #73626

kertal commented Jul 29, 2020 •

edited

Loading

elasticmachine commented Jul 29, 2020

dmlemeshko Jul 29, 2020

kertal Jul 29, 2020

LeeDr Jul 29, 2020 •

edited

Loading

kertal Jul 30, 2020

kertal Jul 30, 2020

kibanamachine commented Jul 30, 2020

dmlemeshko left a comment

LeeDr left a comment

[Discover] Improve saveSearch functional test handling #73626

[Discover] Improve saveSearch functional test handling #73626

Conversation

kertal commented Jul 29, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Jul 29, 2020

dmlemeshko Jul 29, 2020

Choose a reason for hiding this comment

kertal Jul 29, 2020

Choose a reason for hiding this comment

LeeDr Jul 29, 2020 • edited Loading

Choose a reason for hiding this comment

kertal Jul 30, 2020

Choose a reason for hiding this comment

kertal Jul 30, 2020

Choose a reason for hiding this comment

kibanamachine commented Jul 30, 2020

💚 Build Succeeded

Build metrics

History

dmlemeshko left a comment

Choose a reason for hiding this comment

LeeDr left a comment

Choose a reason for hiding this comment

kertal commented Jul 29, 2020 •

edited

Loading

LeeDr Jul 29, 2020 •

edited

Loading