Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Unskips and fixes Cypress tests #73322

Merged
merged 6 commits into from
Jul 28, 2020
+6 −9
Merged

[SIEM] Unskips and fixes Cypress tests #73322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a75275b
removes not needed configuration
MadameSheema Jul 27, 2020
288ef5a
fixes events columnts tests
MadameSheema Jul 27, 2020
0458ef8
unksips persisten timeline test
MadameSheema Jul 27, 2020
e4ddcdf
Merge branch 'master' into unskipping-tests
elasticmachine Jul 27, 2020
8a07ddb
fixes failing test
MadameSheema Jul 28, 2020
63227ea
skips events test since need more time for investigation
MadameSheema Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/plugins/security_solution/cypress/integration/timeline_local_storage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ import { TABLE_COLUMN_EVENTS_MESSAGE } from '../screens/hosts/external_events';
import { waitsForEventsToBeLoaded, openEventsViewerFieldsBrowser } from '../tasks/hosts/events';
import { removeColumn, resetFields } from '../tasks/timeline';

// Failing: See https://github.com/elastic/kibana/issues/72339
describe.skip('persistent timeline', () => {
describe('persistent timeline', () => {
before(() => {
loginAndWaitForPage(HOSTS_URL);
openEvents();
Expand Down
8 changes: 4 additions & 4 deletions x-pack/plugins/security_solution/cypress/tasks/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ export const drag = (subject: JQuery<HTMLElement>) => {
clientY: subjectLocation.top,
force: true,
})
.wait(1000)
.wait(3000)
.trigger('mousemove', {
button: primaryButton,
clientX: subjectLocation.left + dndSloppyClickDetectionThreshold,
clientY: subjectLocation.top,
force: true,
})
.wait(1000);
.wait(3000);
};

/** Drags the subject being dragged on the specified drop target, but does not drop it */
Expand All @@ -44,9 +44,9 @@ export const dragWithoutDrop = (dropTarget: JQuery<HTMLElement>) => {
export const drop = (dropTarget: JQuery<HTMLElement>) => {
cy.wrap(dropTarget)
.trigger('mousemove', { button: primaryButton, force: true })
.wait(1000)
.wait(3000)
.trigger('mouseup', { force: true })
.wait(1000);
.wait(3000);
};

export const reload = (afterReload: () => void) => {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/cypress/tasks/hosts/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const dragAndDropColumn = ({
.eq(column)
.then((header) => drag(header));

cy.wait(3000); // wait for DOM updates before moving
cy.wait(5000); // wait for DOM updates before moving

cy.get(DRAGGABLE_HEADER)
.eq(newPosition)
Expand Down
2 changes: 0 additions & 2 deletions x-pack/test/security_solution_cypress/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
'--csp.strict=false',
// define custom kibana server args here
`--elasticsearch.ssl.certificateAuthorities=${CA_CERT_PATH}`,
'--xpack.ingestManager.enabled=true',
'--xpack.ingestManager.fleet.enabled=true',
],
},
};
Expand Down