Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Unskips and fixes Cypress tests #73322

Merged
merged 6 commits into from
Jul 28, 2020

Conversation

MadameSheema
Copy link
Member

Summary

In this PR we are unkskipping and fixing some Cypress tests.

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 27, 2020
@MadameSheema MadameSheema self-assigned this Jul 27, 2020
@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@MadameSheema MadameSheema marked this pull request as ready for review July 28, 2020 12:09
@MadameSheema MadameSheema requested review from a team as code owners July 28, 2020 12:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally without any issues.

@MadameSheema MadameSheema merged commit 4984683 into elastic:master Jul 28, 2020
@MadameSheema MadameSheema deleted the unskipping-tests branch July 28, 2020 13:23
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 28, 2020
* removes not needed configuration

* fixes events columnts tests

* unksips persisten timeline test

* fixes failing test

* skips events test since need more time for investigation

Co-authored-by: Elastic Machine <[email protected]>
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 28, 2020
* removes not needed configuration

* fixes events columnts tests

* unksips persisten timeline test

* fixes failing test

* skips events test since need more time for investigation

Co-authored-by: Elastic Machine <[email protected]>
MadameSheema added a commit that referenced this pull request Jul 28, 2020
* removes not needed configuration

* fixes events columnts tests

* unksips persisten timeline test

* fixes failing test

* skips events test since need more time for investigation

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
tylersmalley pushed a commit that referenced this pull request Jul 28, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants