[Logs UI] Return empty result sets instead of 500 or 404 for analysis results #72824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
bug
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
weltenwort
added
the
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Jul 27, 2020
… results (elastic#72824) This changes the analysis results routes to return empty result sets with HTTP status code 200 instead of and inconsistent status codes 500 or 404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the analysis results routes to return empty result sets with HTTP status code 200 instead of and inconsistent status codes 500 or 404. This is done by explicitly handling empty query responses instead of relying on the ES response validation and shard count checks.
closes #72651
Rationale
The new API provided by the ML plugin abstracts away the specific results index names. Furthermore the permission model was changed to not use the
machine_learning_*roles anymore, but integrate with the Kibana permissions instead. So checking for the index availability doesn't reliably represent the underlying situation anymore.In addition, the routes represent collections instead of individual resources, which means that 404 responses are inappropriate. Instead empty result sets should be returned if no resources can be found for the query.