Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transforms] Do not throw an error when agg is not supported by UI #72685

Merged

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Jul 21, 2020

Summary

The function that resolves UI agg representation object from the JSON ES agg definition was throwing an error silently and preventing advanced JSON config editor to apply changes. Now it allows to add any aggregation and the validation happens only by calling the _preview endpoint.

@darnautov darnautov added bug Fixes for quality problems that affect the customer experience :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.10.0 v7.9.0 labels Jul 21, 2020
@darnautov darnautov requested a review from a team as a code owner July 21, 2020 16:14
@darnautov darnautov self-assigned this Jul 21, 2020
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the example which uses a bucket_script on the Flights sample data set in the docs, and was able to create the transform successfully.

I noted that the aggregation which uses the bucket_script doesn't appear in the preview table.

image

And if I use the popover to make an edit to the bucket_script aggregation after adding it to the transform e.g. to change the name of the aggregation, I see this error in the preview area:

image

@walterra are the above known issues?

Approving as this fixes the specific bug around not being able to add an aggregation using bucket_script.

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
transform 705.2KB -30.0B 705.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit b3f1595 into elastic:master Jul 21, 2020
@darnautov darnautov deleted the transforms-fix-unsupported-agg-error branch July 21, 2020 23:03
peteharverson pushed a commit to peteharverson/kibana that referenced this pull request Jul 22, 2020
peteharverson pushed a commit to peteharverson/kibana that referenced this pull request Jul 22, 2020
darnautov added a commit to darnautov/kibana that referenced this pull request Jul 22, 2020
darnautov added a commit to darnautov/kibana that referenced this pull request Jul 22, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 22, 2020
* master: (23 commits)
  Stabilize closing toast (elastic#72097)
  stabilize failing test (elastic#72086)
  Stabilize filter bar test (elastic#72032)
  Unskip vislib tests (elastic#71452)
  [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689)
  fix preAuth/preRouting mocks (elastic#72663)
  [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788)
  [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584)
  [Security Solution] Fixes exception modal not loading content (elastic#72770)
  [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748)
  [Detections] Add validation for Threshold value field (elastic#72611)
  [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730)
  [Security Solution][Detections] Validate file type of value lists (elastic#72746)
  [pre-req] New Component Layout proposal (elastic#72385)
  [ML] do not throw an error when agg is not supported by UI (elastic#72685)
  [Resolver] Origin process (elastic#72382)
  [Ingest Manager] Allow to force unenroll from the UI (elastic#72386)
  skip 6.8 branch when triggering baseline-capture builds (elastic#72706)
  [CI] In-progress PR comments (elastic#72211)
  Fix sorting of scripted string fields (elastic#72681)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants