-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolver] Origin process #72382
[Resolver] Origin process #72382
Conversation
3ea8ede
to
d6ef04f
Compare
d6ef04f
to
ca2b27f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 code looks fine, the way the process looks not so sure
12bceab
to
b0d689b
Compare
} | ||
|
||
/** | ||
* Return a clone of `model` with all positions incremented by `position`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ Assume by position
in this comment you mean translation: Vector2
in the args as below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -94,6 +94,6 @@ async function indexAlerts( | |||
}, | |||
[] | |||
); | |||
await client.bulk({ body, refresh: true }); | |||
await client.bulk({ body, refresh: 'true' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typescript error
} | ||
|
||
/** | ||
* Return a clone of `model` with all positions incremented by `position`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
} | ||
|
||
/** | ||
* Return a clone of `model` with all positions incremented by `position`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Return a clone of `model` with all positions incremented by `position`. | |
* Return a clone of `model` with all positions incremented by `translation`. |
const taxiLayout = isometricTaxiLayoutModel.isometricTaxiLayoutFactory(indexedProcessTree); | ||
|
||
if (!originID) { | ||
// TODO, this should only happen when no data has loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove TODO
return taxiLayout; | ||
} | ||
|
||
// subtract the origin position from the layout, centering the layout around the origin node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO elaborate on how this works in comments
@@ -212,7 +207,7 @@ const UnstyledProcessEventDot = React.memo( | |||
isLabelFilled, | |||
labelButtonFill, | |||
strokeColor, | |||
} = cubeAssetsForNode(isProcessTerminated, isProcessOrigin); | |||
} = cubeAssetsForNode(isProcessTerminated, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't defined yet. we dont have a way to know if its a trigger? TODO add comment
return { | ||
...uiState, | ||
activeDescendantId: action.payload.nodeId, | ||
const next: ResolverUIState = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by using const next: ResolverUIState
, typescript will complain about excess properties.
return nodeAssets[processTypeToCube.processTerminated]; | ||
} else if (isProcessOrigin) { | ||
if (isProcessTrigger) { | ||
return nodeAssets.terminatedTriggerCube; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
show the special terminated trigger cube.
* EuiPopover has a mutation observer that observers the child tree and repositions itself. | ||
* Abuse this to cause it to reposition itself when the project matrix changes. | ||
*/} | ||
<HiddenSpan data-force-mutation-observer={projectionMatrix.join(', ')} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 still see our little experiment here.
useMemo, | ||
useCallback, | ||
useRef, | ||
useLayoutEffect, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useLayoutEffect, |
CI freaked out on this
1b94170
to
8d8f443
Compare
also renames 'isProcessOrigin' params in resolver theme to be 'isProcessTrigger'. NB: this does not use the trigger node styling
UI state changes: * rename `activeDescendantId` to `ariaActiveDescendant`. it has the nodeID (aka entity_id) of the aria active descendant * rename `processEntityIdOfSelectedDescendant` to `selectedNode`. it has the nodeID (aka entity_id) of the selected node * aria html attributes were wrong (this also effected styling.)
90c24af
to
d8e051c
Compare
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
* master: (23 commits) Stabilize closing toast (elastic#72097) stabilize failing test (elastic#72086) Stabilize filter bar test (elastic#72032) Unskip vislib tests (elastic#71452) [ML] Fix layout of anomaly chart tooltip for long field values (elastic#72689) fix preAuth/preRouting mocks (elastic#72663) [Security Solution] Hide KQL bar (all pages) and alerts filters (Detections) when Resolver is full screen (elastic#72788) [Uptime] Rename Whitelist to Allowlist in parse_filter_map (elastic#71584) [Security Solution] Fixes exception modal not loading content (elastic#72770) [Security Solution][Exceptions] - Require non empty entries and non empty string values in exception list items (elastic#72748) [Detections] Add validation for Threshold value field (elastic#72611) [SIEM][Detection Engine][Lists] Adds version and immutability data structures (elastic#72730) [Security Solution][Detections] Validate file type of value lists (elastic#72746) [pre-req] New Component Layout proposal (elastic#72385) [ML] do not throw an error when agg is not supported by UI (elastic#72685) [Resolver] Origin process (elastic#72382) [Ingest Manager] Allow to force unenroll from the UI (elastic#72386) skip 6.8 branch when triggering baseline-capture builds (elastic#72706) [CI] In-progress PR comments (elastic#72211) Fix sorting of scripted string fields (elastic#72681) ...
Co-authored-by: Brent Kimmel <[email protected]> * Center the origin node * Nodes appear selected when they are selected. also the aria attributes are working. * Reposition the submenu when the user pans.
Co-authored-by: Brent Kimmel <[email protected]> * Center the origin node * Nodes appear selected when they are selected. also the aria attributes are working. * Reposition the submenu when the user pans.
Co-authored-by: Brent Kimmel <[email protected]> * Center the origin node * Nodes appear selected when they are selected. also the aria attributes are working. * Reposition the submenu when the user pans.
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Co-authored-by: Brent Kimmel <[email protected]> * Center the origin node * Nodes appear selected when they are selected. also the aria attributes are working. * Reposition the submenu when the user pans. Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Brent Kimmel [email protected]
closes https://github.com/elastic/endpoint-app-team/issues/579
Summary
Note: this doesn't include the following. We need a follow up PR
Generally works:
Origin is in the center, selecting nodes works, and the submenu is correctly repositioned when the graph moves.
panels still work
Checklist
Delete any items that are not applicable to this PR.
For maintainers