Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Fix issue with ES node detail status #72298

Merged
merged 2 commits into from
Jul 17, 2020
Merged

[Monitoring] Fix issue with ES node detail status #72298

merged 2 commits into from
Jul 17, 2020

Conversation

chrisronline
Copy link
Contributor

Fixes #72159

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 17, 2020
@chrisronline chrisronline requested a review from a team July 17, 2020 15:23
@chrisronline chrisronline self-assigned this Jul 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline mentioned this pull request Jul 17, 2020
Closed
@chrisronline chrisronline requested review from a team as code owners July 17, 2020 16:35
@chrisronline chrisronline requested a review from a team July 17, 2020 16:35
@chrisronline chrisronline requested a review from a team as a code owner July 17, 2020 16:35
@chrisronline chrisronline requested a review from a team July 17, 2020 16:35
@chrisronline chrisronline requested review from a team as code owners July 17, 2020 16:35
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@chrisronline chrisronline force-pushed the monitoring/alerts_node_detail_status branch from a932985 to 7df0cd0 Compare July 17, 2020 16:36
@chrisronline chrisronline removed request for a team July 17, 2020 16:37
@chrisronline chrisronline removed Team:Fleet Team label for Observability Data Collection Fleet team Team:APM All issues that need APM UI Team support labels Jul 17, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
monitoring 1.1MB +509.0B 1.1MB

History

  • 💛 Build #62668 was flaky 180280872856e6f7ffd5fe72e7d0c4392c9198a5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jasonrhodes
jasonrhodes approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screen Shot 2020-07-17 at 5 00 47 PM

Seeing some EUI related nesting errors in the console, but they look like warnings, just pointing them out for posterity.

Screen Shot 2020-07-17 at 5 10 13 PM

@chrisronline chrisronline merged commit f0d3cb9 into elastic:master Jul 17, 2020
@chrisronline chrisronline deleted the monitoring/alerts_node_detail_status branch July 17, 2020 21:15
This was referenced Jul 17, 2020
Merged
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jul 17, 2020
@chrisronline
[Monitoring] Fix issue with ES node detail status (elastic#72298)
a48fc3c 
* Fix issue with ES node detail status

* Add test
chrisronline added a commit that referenced this pull request Jul 17, 2020
@chrisronline @elasticmachine
[Monitoring] Fix issue with ES node detail status (#72298) (#72350)
6c0e671 
* Fix issue with ES node detail status

* Add test

Co-authored-by: Elastic Machine <[email protected]>
chrisronline added a commit that referenced this pull request Jul 17, 2020
@chrisronline @elasticmachine
[Monitoring] Fix issue with ES node detail status (#72298) (#72349)
c65e781 
* Fix issue with ES node detail status

* Add test

Co-authored-by: Elastic Machine <[email protected]>
@chrisronline
Copy link
Contributor Author

Backport

7.x: c65e781
7.9: 6c0e671

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 20, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
6b14aaf 
* master:
  [Observability] Remove app logos (elastic#72259)
  Fix float percentiles line chart (elastic#71902)
  update chromedriver to 84 (elastic#72228)
  [esArchiver] actually re-delete the .kibana index if we lose recreate race (elastic#72354)
  [Maps] convert SavedGisMap to TS (elastic#72286)
  [DOCS] Removes occurrences of X-Pack Security and Reporting (elastic#72302)
  use WORKSPACE env var for stack_functional_integration tests, fix navigate path (elastic#71908)
  [Monitoring] Fix issue with ES node detail status (elastic#72298)
  [SIEM] Updates consumer in export_rule archive (elastic#72324)
  [kbn/dev-utils] add RunWithCommands utility (elastic#72311)
  [Security Solution][Endpoint][Exceptions] Only write manifest to policy when there are changes (elastic#72000)
  skip flaky suite (elastic#72339)
  [ML] Fix annotations pagination & change labels from letters to numbers (elastic#72204)
  [Lens] Fix switching with layers (elastic#71982)
  [Maps] 7.9 documenation updates (elastic#71893)
  docs: ✏️ add "Explore underlying data" user docs (elastic#70807)
  [Security Solution][Exceptions] - Remove initial add exception item button in builder (elastic#72215)
  Fix indentation level in code exploration doc (elastic#72274)
  register graph usage (elastic#72041)
  [Monitoring] Added a case for Alerting if security/ssl is disabled (elastic#71846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrhodes jasonrhodes jasonrhodes approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monitoring logs for elasticsearch nodes advanced is throwing an exception
4 participants
@chrisronline @elasticmachine @kibanamachine @jasonrhodes