-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use WORKSPACE env var for stack_functional_integration tests, fix navigate path #71908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeDr
changed the title
Stack integration update
add a saml login option for stack_functional_integration tests
Jul 15, 2020
LeeDr
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:QA
Team label for QA Team
v7.10.0
v7.8.2
v7.9.0
v8.0.0
labels
Jul 15, 2020
@elasticmachine merge upstream |
@elasticmachine merge upstream |
1 similar comment
@elasticmachine merge upstream |
@elasticmachine merge upstream |
LeeDr
changed the title
add a saml login option for stack_functional_integration tests
use WORKSPACE env var for stack_functional_integration tests, fix navigate path
Jul 17, 2020
Pinging @elastic/kibana-qa (Team:QA) |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
wayneseymour
approved these changes
Jul 17, 2020
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Jul 17, 2020
…igate path (elastic#71908) Co-authored-by: Elastic Machine <[email protected]>
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Jul 17, 2020
…igate path (elastic#71908) Co-authored-by: Elastic Machine <[email protected]>
LeeDr
pushed a commit
that referenced
this pull request
Jul 18, 2020
…ix navigate path (#71908) (#72355) Co-authored-by: Elastic Machine <[email protected]>
LeeDr
pushed a commit
that referenced
this pull request
Jul 18, 2020
…ix navigate path (#71908) (#72356) Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 20, 2020
* master: [Observability] Remove app logos (elastic#72259) Fix float percentiles line chart (elastic#71902) update chromedriver to 84 (elastic#72228) [esArchiver] actually re-delete the .kibana index if we lose recreate race (elastic#72354) [Maps] convert SavedGisMap to TS (elastic#72286) [DOCS] Removes occurrences of X-Pack Security and Reporting (elastic#72302) use WORKSPACE env var for stack_functional_integration tests, fix navigate path (elastic#71908) [Monitoring] Fix issue with ES node detail status (elastic#72298) [SIEM] Updates consumer in export_rule archive (elastic#72324) [kbn/dev-utils] add RunWithCommands utility (elastic#72311) [Security Solution][Endpoint][Exceptions] Only write manifest to policy when there are changes (elastic#72000) skip flaky suite (elastic#72339) [ML] Fix annotations pagination & change labels from letters to numbers (elastic#72204) [Lens] Fix switching with layers (elastic#71982) [Maps] 7.9 documenation updates (elastic#71893) docs: ✏️ add "Explore underlying data" user docs (elastic#70807) [Security Solution][Exceptions] - Remove initial add exception item button in builder (elastic#72215) Fix indentation level in code exploration doc (elastic#72274) register graph usage (elastic#72041) [Monitoring] Added a case for Alerting if security/ssl is disabled (elastic#71846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
config.stack_functional_integration_base.js
we need to use the WORKSPACE Jenkins env var in the path.x-pack/test/stack_functional_integration/test/functional/apps/sample_data/e_commerce.js
I'm setting the parameters for the navigate method back to those that work in master. I'll have to test this on each backport branch.Checklist
Delete any items that are not applicable to this PR.
For maintainers