Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a value is deleted from the nav link collection, invalidate in-order cache #7227

Merged
merged 2 commits into from
May 18, 2016
Merged

If a value is deleted from the nav link collection, invalidate in-order cache #7227

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
079aba6
If value is deleted from the nav link collection, invalidate cache
ycombinator May 18, 2016
c2afeda
Return value of superclass's delete, preserving API
ycombinator May 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ui/ui_nav_link_collection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,9 @@ export default class UiNavLinkCollection extends Collection {
return this[inOrderCache];
}

delete(value) {
super.delete(value);
this[inOrderCache] = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this before super.delete() and returning the calls return value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense as delete returns a boolean. Thanks!

}

};