If a value is deleted from the nav link collection, invalidate in-order cache #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the next time inOrder is called, the stale nav link collection that is in the cache is returned, with the deleted object still in it.
| @@ -26,4 +26,9 @@ export default class UiNavLinkCollection extends Collection { | |||
| return this[inOrderCache]; | |||
| } | |||
|
|
|||
| delete(value) { | |||
| super.delete(value); | |||
| this[inOrderCache] = null; | |||
There was a problem hiding this comment.
How about moving this before super.delete() and returning the calls return value?
There was a problem hiding this comment.
Yeah, makes sense as delete returns a boolean. Thanks!
|
LGTM |
|
I'm singling this PR out purely for convenience sake: Especially for PRs that don't have an associated issue, it'd be really helpful to provide a description about what problem is being solved. |
|
Makes sense. I'll update the description now. |
|
@epixa Description updated. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UiNavLinkCollectionclass maintains a list of nav links shown in the Kibana UI. Instances of this class have a property calledinOrderCachethat is meant to contain the list of nav links, in order of theirorderproperties. ThisinOrderCacheproperty is populated when theinOrder()instance method is called the first time; subsequent calls to theinOrder()method simply return the list ininOrderCache.As the
UiNavLinkCollectioninherits from theCollectionclass, it also has adelete()instance method that can be called to delete a nav link from the list of nav links. Thisdelete()method needs to be overriden to invalidate theinOrderCacheeach time a link is deleted. Otherwise, the next timeinOrder()is called, the stale cached nav link collection is returned, with the deleted object still in it. This PR implements this fix.